New issue
Advanced search Search tips

Issue 777012 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Samsung DeX no longer considers Chromium as a resizable window

Project Member Reported by cblume@chromium.org, Oct 20 2017

Issue description

Somewhere along the way we have broken Android N multi-window support? Or at least what Samsung considers enough to make windows re-sizable. You can read more here [1] under "Samsung DeX window types". The browser used to be re-sizable and is now fixed size.

+twellington@ I saw you had recently added some multi-window changes for Samsung. Could this be related?

Also, did we move the android:resizeableActivity="true" in such a way that it might not be applying here?

[1] http://developer.samsung.com/samsung-dex/how-it-works
 
Cc: cblume@chromium.org dskiba@chromium.org
clbume@ - What version of Chrome are you experiencing this issue on? I recently removed support for Samsung's legacy multi-instance mode, but that shouldn't have impacted multi-window.

+dskiba@ has been making some changes to AndroidManifest.xml that moved various things around.

Samsung multiwindow location in AndroidManifest.xml:
https://cs.chromium.org/chromium/src/chrome/android/java/AndroidManifest.xml?type=cs&q=androidmanifest.xml&sq=package:chromium&l=136

Comment 2 by dskiba@chromium.org, Oct 20 2017

I think this can be related to my change. Right now ChromeTabbedActivity (which is still android:resizeableActivity) is started via .Main alias when you click a Launcher icon, and I can see how code can confused.

Do you have DeX setup at work? I would like to take a look.

Comment 3 by cblume@chromium.org, Oct 21 2017

I do have a DeX setup. It is at my desk.
I will be on vacation next week. If you want to borrow it, take:
- the plastic dock to the back right of my desk,
- the phone in the doc
- the power cable (requires a lot of juice...more than a normal adapter can handle)
- the wireless mouse (next to my wired mouse)

Alternatively, since this isn't a high priority...
If you have an idea of what might fix it I can try it out for you when I get back.
Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment