gmock has deprecated testing::SetArgumentPointee, which is superseded by the equivalent testing::SetArgPointee
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/85ceaedc70b230d83823fd647c95992e1812773f commit 85ceaedc70b230d83823fd647c95992e1812773f Author: Ben Chan <benchan@chromium.org> Date: Sat Oct 21 06:55:11 2017 permission_broker: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: I0cf489518c73405643a3edcd296bc76dab83480c Reviewed-on: https://chromium-review.googlesource.com/731783 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/85ceaedc70b230d83823fd647c95992e1812773f/permission_broker/port_tracker_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4cd8465e0f7187dad285829e90742bceb71cde00 commit 4cd8465e0f7187dad285829e90742bceb71cde00 Author: Ben Chan <benchan@chromium.org> Date: Sat Oct 21 06:55:10 2017 login: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: I37c58cb0d5b4a91afa1478bb83e9751401c6c616 Reviewed-on: https://chromium-review.googlesource.com/731784 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/4cd8465e0f7187dad285829e90742bceb71cde00/login_manager/session_manager_impl_unittest.cc [modify] https://crrev.com/4cd8465e0f7187dad285829e90742bceb71cde00/login_manager/policy_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2f4bfc5c281cd919b34f24a4abfb14891ef0a514 commit 2f4bfc5c281cd919b34f24a4abfb14891ef0a514 Author: Ben Chan <benchan@chromium.org> Date: Sat Oct 21 06:55:09 2017 cros-disks: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: Iae930b7841ae4a47778922a90f68157cf730021b Reviewed-on: https://chromium-review.googlesource.com/731785 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/2f4bfc5c281cd919b34f24a4abfb14891ef0a514/cros-disks/device_event_moderator_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518 commit ff537c6ce46107e1b1868c13a32ae8fe3ce5f518 Author: Ben Chan <benchan@chromium.org> Date: Sat Oct 21 06:55:10 2017 chaps: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: Ifa39c6816cd1e4d7f0e1268d870a5959e9d69e35 Reviewed-on: https://chromium-review.googlesource.com/731786 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/object_policy_test.cc [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/chaps_service_test.cc [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/session_test.cc [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/object_pool_test.cc [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/opencryptoki_importer_test.cc [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/slot_manager_test.cc [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/tpm_utility_test.cc [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/chaps_pam_module_test.cc [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/chaps_test.cc [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/isolate_login_client_test.cc [modify] https://crrev.com/ff537c6ce46107e1b1868c13a32ae8fe3ce5f518/chaps/object_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f6ec0293bbb2fb2194a463c7d9bacb8693f6cc77 commit f6ec0293bbb2fb2194a463c7d9bacb8693f6cc77 Author: Ben Chan <benchan@chromium.org> Date: Sat Oct 21 06:55:11 2017 gobi-cromo-plugin: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: I70d1243fe85c179f70e9429a9ae01664df3bdcbd Reviewed-on: https://chromium-review.googlesource.com/731787 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f6ec0293bbb2fb2194a463c7d9bacb8693f6cc77/gobi-cromo-plugin/gobi_modem_unittest.cc
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/thermald/+/f265df69ae3ea0833e752e779fbf3588a172e643 commit f265df69ae3ea0833e752e779fbf3588a172e643 Author: Ben Chan <benchan@chromium.org> Date: Sun Oct 22 19:34:29 2017
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/261fd9211cd43b9d842876281eb53f13f972a8a6 commit 261fd9211cd43b9d842876281eb53f13f972a8a6 Author: Ben Chan <benchan@chromium.org> Date: Mon Oct 23 22:22:17 2017 shill: wifi: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: Ifa1db375b66a6a41d1a723d599b32a40de6032cd Reviewed-on: https://chromium-review.googlesource.com/731788 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/261fd9211cd43b9d842876281eb53f13f972a8a6/wifi/wifi_unittest.cc [modify] https://crrev.com/261fd9211cd43b9d842876281eb53f13f972a8a6/wifi/wifi_service_unittest.cc [modify] https://crrev.com/261fd9211cd43b9d842876281eb53f13f972a8a6/wifi/mac80211_monitor_unittest.cc [modify] https://crrev.com/261fd9211cd43b9d842876281eb53f13f972a8a6/wifi/wifi_provider_unittest.cc [modify] https://crrev.com/261fd9211cd43b9d842876281eb53f13f972a8a6/wifi/tdls_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/667126b0019a604f57c5e1e11dea055b3cc2a582 commit 667126b0019a604f57c5e1e11dea055b3cc2a582 Author: Ben Chan <benchan@chromium.org> Date: Mon Oct 23 22:22:17 2017 shill: vpn: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: I22a9e428632377d74aaada7053d94fe41d8c4231 Reviewed-on: https://chromium-review.googlesource.com/731789 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/667126b0019a604f57c5e1e11dea055b3cc2a582/vpn/arc_vpn_driver_unittest.cc [modify] https://crrev.com/667126b0019a604f57c5e1e11dea055b3cc2a582/vpn/third_party_vpn_driver_unittest.cc [modify] https://crrev.com/667126b0019a604f57c5e1e11dea055b3cc2a582/vpn/openvpn_driver_unittest.cc [modify] https://crrev.com/667126b0019a604f57c5e1e11dea055b3cc2a582/vpn/vpn_driver_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/61db3175403035674d535862c8f3bf6e47f37a56 commit 61db3175403035674d535862c8f3bf6e47f37a56 Author: Ben Chan <benchan@chromium.org> Date: Mon Oct 23 22:22:18 2017 shill: cellular replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: I66220ca2aa95ea9925c758cd696b10e88691de0f Reviewed-on: https://chromium-review.googlesource.com/731790 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/61db3175403035674d535862c8f3bf6e47f37a56/cellular/modem_unittest.cc [modify] https://crrev.com/61db3175403035674d535862c8f3bf6e47f37a56/cellular/modem_1_unittest.cc [modify] https://crrev.com/61db3175403035674d535862c8f3bf6e47f37a56/cellular/cellular_service_unittest.cc [modify] https://crrev.com/61db3175403035674d535862c8f3bf6e47f37a56/cellular/cellular_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/6ef5957de96c6a38fe17ab1e9d7e384c512c089f commit 6ef5957de96c6a38fe17ab1e9d7e384c512c089f Author: Ben Chan <benchan@chromium.org> Date: Mon Oct 23 22:22:18 2017 shill: ethernet: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: I912473c4b06bcf391e7caef8f60ea12a1c112db9 Reviewed-on: https://chromium-review.googlesource.com/731791 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/6ef5957de96c6a38fe17ab1e9d7e384c512c089f/ethernet/ethernet_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/b19cabdf0da44ca0b1aa285c30e4c4b500a3e814 commit b19cabdf0da44ca0b1aa285c30e4c4b500a3e814 Author: Ben Chan <benchan@chromium.org> Date: Mon Oct 23 22:22:18 2017 shill: dhcp: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: I26d12c46647ba99e3812d8397ba19dd900e7a8b4 Reviewed-on: https://chromium-review.googlesource.com/731792 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/b19cabdf0da44ca0b1aa285c30e4c4b500a3e814/dhcp/dhcpv4_config_unittest.cc [modify] https://crrev.com/b19cabdf0da44ca0b1aa285c30e4c4b500a3e814/dhcp/dhcp_properties_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/e4c66658bac53ca75646360f079dabf414ce7789 commit e4c66658bac53ca75646360f079dabf414ce7789 Author: Ben Chan <benchan@chromium.org> Date: Mon Oct 23 22:22:18 2017 shill: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: Id92fc60616a1355b8db963f57b4aa27c151fe600 Reviewed-on: https://chromium-review.googlesource.com/731793 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/power_manager_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/dns_client_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/process_manager_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/connection_diagnostics_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/eap_credentials_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/service_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/static_ip_parameters_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/link_monitor_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/active_link_monitor_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/connection_health_checker_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/pending_activation_store_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/default_profile_unittest.cc [modify] https://crrev.com/e4c66658bac53ca75646360f079dabf414ce7789/metrics_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/tpm/+/6d581977f4f2728cb8187b6804b68735614767ad commit 6d581977f4f2728cb8187b6804b68735614767ad Author: Ben Chan <benchan@chromium.org> Date: Tue Oct 24 05:39:04 2017 Replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: I82fa9004cf76f3f47cfcfa9781717fb4da24cf6d Reviewed-on: https://chromium-review.googlesource.com/734216 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/6d581977f4f2728cb8187b6804b68735614767ad/attestation/server/attestation_service_test.cc [modify] https://crrev.com/6d581977f4f2728cb8187b6804b68735614767ad/trunks/resource_manager_test.cc [modify] https://crrev.com/6d581977f4f2728cb8187b6804b68735614767ad/attestation/server/pkcs11_key_store_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/apmanager/+/5f43fb626cf8bba55580bc8781beb6234444366c commit 5f43fb626cf8bba55580bc8781beb6234444366c Author: Ben Chan <benchan@chromium.org> Date: Tue Oct 24 07:36:59 2017 apmanager: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: I4a4c71e5173bb5a988ae0732923b19a2f4c2afff Reviewed-on: https://chromium-review.googlesource.com/734331 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/5f43fb626cf8bba55580bc8781beb6234444366c/config_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/672c1f54a499a825cc0bb9bc4f240bf1887550d9 commit 672c1f54a499a825cc0bb9bc4f240bf1887550d9 Author: Ben Chan <benchan@chromium.org> Date: Tue Oct 24 22:30:15 2017 update_engine: replace testing::SetArgumentPointee with testing::SetArgPointee testing::SetArgumentPointee defined in gmock has been deprecated and superseded by an equivalent testing::SetArgPointee. BUG= chromium:777011 TEST=Run unit tests. Change-Id: Ifc48897148d721e6f65159a54586e1fb456d75b9 Reviewed-on: https://chromium-review.googlesource.com/735213 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/672c1f54a499a825cc0bb9bc4f240bf1887550d9/certificate_checker_unittest.cc [modify] https://crrev.com/672c1f54a499a825cc0bb9bc4f240bf1887550d9/update_attempter_unittest.cc [modify] https://crrev.com/672c1f54a499a825cc0bb9bc4f240bf1887550d9/omaha_request_action_unittest.cc [modify] https://crrev.com/672c1f54a499a825cc0bb9bc4f240bf1887550d9/common_service_unittest.cc [modify] https://crrev.com/672c1f54a499a825cc0bb9bc4f240bf1887550d9/payload_consumer/delta_performer_unittest.cc [modify] https://crrev.com/672c1f54a499a825cc0bb9bc4f240bf1887550d9/payload_state_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Oct 21 2017