New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777005 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 721802



Sign in to add a comment

Auto fullscreen-in-tab media router initiated local media video

Project Member Reported by amp@chromium.org, Oct 20 2017

Issue description

Local media casting (see issue 721802) opens up a new tab with the local content.

As there is no other content in the tab except for the media and that media is immediately captured and sent to a remote sink (chromecast etc) the content should be fullscreen for the optimal experience.
 

Comment 1 by mfo...@chromium.org, Oct 20 2017

It seems to me one of the benefits of casting vs. local playback is to retain control of your local browser window and multitask while the media plays elsewhere.  Playing the media fullscreen doesn't really allow that (or requires an extra step to get back to the browser window).  Does this proposal align with the feature PRD?

Comment 2 by amp@chromium.org, Oct 20 2017

I created this specifically for https://chromium-review.googlesource.com/c/chromium/src/+/731669 instead of tagging it to the launch bug as Anna's original change had it.

And to be clear this is fullscreen after the capture is started, so it's fullscreen-in-tab, not actual fullscreen.

My description may be off from the PRD says, but I believe this was all planned work and in fact the only thing left blocking the launch.

Comment 3 by mfo...@chromium.org, Oct 20 2017

Okay, fullscreen-in-tab makes much more sense.  Maybe edit the original description to clarify.

Comment 4 by amp@chromium.org, Oct 20 2017

Summary: Auto fullscreen-in-tab media router initiated local media video (was: Fullscreen media router initiated local media video)

Comment 5 by amp@chromium.org, Dec 8 2017

Blocking: 721802
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06

commit 6a19ba34ce27c038df1abb91cf72c9b01ae8fc06
Author: Adam Parker <amp@chromium.org>
Date: Tue Jan 09 00:47:28 2018

[Local Media Casting] Automatically fullscreen local media casting video files.

This change adds back a previously removed blink API on WebElement to
fullscreen an element.

This API is then wired up to media router UI and the local media casting flow to
fullscreen the first video element as soon as it is loaded.

Bug:  777005 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I3d4e24c2a8d45edbfa612312a21053086750df11
Reviewed-on: https://chromium-review.googlesource.com/731669
Commit-Queue: Adam Parker <amp@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527835}
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/chrome/test/media_router/BUILD.gn
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/chrome/test/media_router/media_router_e2e_ui_browsertest.cc
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/chrome/test/media_router/media_router_integration_browsertest.cc
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/chrome/test/media_router/media_router_integration_browsertest.h
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/chrome/test/media_router/resources/local_media_sink.json
[add] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/chrome/test/media_router/resources/local_media_sink_route_fail.json
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/content/public/common/BUILD.gn
[add] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/content/public/common/fullscreen_video_element.mojom
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/content/renderer/render_frame_impl.h
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/third_party/WebKit/Source/core/exported/WebElement.cpp
[modify] https://crrev.com/6a19ba34ce27c038df1abb91cf72c9b01ae8fc06/third_party/WebKit/public/web/WebElement.h

Comment 7 by amp@chromium.org, Jan 17 2018

Status: Fixed (was: Started)

Sign in to add a comment