Should fetch qemu binaries on demand for CrOS tests |
|||||||||
Issue descriptionIn order to run full CrOS tests on the bots, we want to be able to run an image in a nested VM on GCE; in order to do that, we need a version of qemu that'll run the image. There is currently a binary in the fuchsia SDK, but it apparently isn't quite built with what we need for CrOS (no SDL support?), so for the moment I'll upload a separate binary using CIPD.
,
Oct 21 2017
,
Oct 24 2017
,
Jan 11 2018
,
Jan 11 2018
Taking this and all related cros efforts. Will look into using cipd since that's what we seem to be converging on for runhook-related fetches.
,
Jan 11 2018
Fuchsia wants something similar and is similarly blocked on improved gclient support for cipd.
,
Jan 11 2018
This bug is related to https://bugs.chromium.org/p/chromium/issues/detail?id=733875 And I have a CL in progress to fix this: https://chromium-review.googlesource.com/860903 This downloads a prebuilt QEMU binary when you enter the chrome sdk shell with --download-vm
,
Jan 11 2018
@achuith: Thanks for the pointer; it sounds like your cl would resolve this. Unless I'm misunderstanding things, I think we can dupe this into bug 733875 ? @jbudorick: OOC, why is fuchsia not satisfied with the current state of things? IIUC, a gclient hook downloads the fuchsia sdk via cipd, within which is a prebuilt qemu binary. I ask cause I'm wondering if the limitations of that approach would apply to Achuith's solution above...
,
Jan 11 2018
I'd like to have a single qemu CIPD package for both OS'es; I believe that'll require the Fuchsia folks to tweak their build a bit, but will hopefully be uncontroversial. I don't recall offhand what is missing, but I wouldn't be surprised if things are.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/6fe29419beee3479772c86cc8baa91e709931caa commit 6fe29419beee3479772c86cc8baa91e709931caa Author: Benjamin Pastene <bpastene@chromium.org> Date: Mon Jan 29 22:29:31 2018 depot_tools: Add a checkout_chromeos conditional var to gclient. This is necessary for https://chromium-review.googlesource.com/c/chromium/src/+/882196. Bug: 776987 Change-Id: Iec0a960a7d80f3ddbc0252073e30abc5a243f06c Reviewed-on: https://chromium-review.googlesource.com/882318 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> [modify] https://crrev.com/6fe29419beee3479772c86cc8baa91e709931caa/gclient.py
,
Jan 30 2018
,
Apr 25 2018
I think this is fixed now. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dpranke@chromium.org
, Oct 20 2017