New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776986 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Keep the ON/OFF toggle to disabled when an extension is re-uploaded with a manifest error

Project Member Reported by catmulli...@chromium.org, Oct 20 2017

Issue description

If an extension is uploaded and then re-uploaded with a manifest.json error, an "Error Loading Extension" dialog appears and the extension is disabled.

However, after closing the dialog, the user can still switch the disable/enable toggle to enabled. After a page refresh, the toggle is switched to disabled. Though the user can still toggle it to enabled.

The user should not be allowed to enable the extension in this case. If this scenario is reproduced on the non-material design chrome://extensions page, the toggle always remains disabled.
 
Status: Available (was: Assigned)
This bug is related to crbug/776994, but is not blocking crbug/776994.
Owner: ----
Owner: catmulli...@chromium.org
Status: Assigned (was: Available)

Comment 5 by bettes@chromium.org, Dec 11 2017

That's a good idea. There's precedent in the mocks to disable an extension based off an error so we can do the same here. I'm not sure if an action button is necessary in this case, but there's examples of both below. 

With an action button:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/04-Extensions/Preview%20+%20Spec/preview#%2Fextension-error-states-error_unknown_details.png%3Fz=width

Without an action button: 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/04-Extensions/Preview%20+%20Spec/preview#%2Fextension-error-states-error_vulnerability_details.png%3Fz=width
Screen Shot 2017-12-11 at 3.54.52 PM.png
64.4 KB View Download

Comment 6 by dpa...@chromium.org, Dec 13 2017

Labels: -Pri-3 Pri-2
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment