New issue
Advanced search Search tips

Issue 776973 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

remove TestDownloadRequestHandler and port all tests to use EmbeddedTestServer

Project Member Reported by qin...@chromium.org, Oct 20 2017

Issue description

TestDownloadRequestHandler uses URlRequestinterceptor, and it doesn't work with network service.

Need to port all the tests to use EmbeddedTestServer instead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16f761349c375d769a7ebd0525b50403ed832acb

commit 16f761349c375d769a7ebd0525b50403ed832acb
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jan 11 22:57:33 2018

Fix DownloadExtensionTest with network service

Also try renabling these tests on Windows since the output from previous flakes was related to
URLRequests which aren't used anymore.

Sheriffs: if these tests flake on Windows, please redisable all the tests via the ifdef that I
removed instead of reverting.

Bug:  769401 , 776973 , 306144 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ice922d72c8911e5daa6d8b038d8496e681f8e8ec
Reviewed-on: https://chromium-review.googlesource.com/859116
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Min Qin(OOO 12/7-1/10) <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528794}
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/chrome/test/ppapi/ppapi_filechooser_browsertest.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/browser/download/download_item_impl.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/browser/download/resource_downloader.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/browser/download_item.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/test/fake_download_item.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/test/fake_download_item.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/test/mock_download_item.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/test/network_service_test_helper.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/test/test_download_http_response.h
[delete] https://crrev.com/f5e97c7c18f90cefd0948e547e2e4253e411f5b5/content/public/test/test_download_request_handler.cc
[delete] https://crrev.com/f5e97c7c18f90cefd0948e547e2e4253e411f5b5/content/public/test/test_download_request_handler.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/test/BUILD.gn
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 2 by jam@chromium.org, Jan 17 2018

Cc: qin...@chromium.org
Owner: jam@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment