New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776967 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Adding metrics for Browser Actions

Reported by ltian@chromium.org, Oct 20 2017

Issue description

Current plan for the metrics includes:
1. User action for browser actions launched
2. Histogram of actions selected (all custom actions grouped into an “app-provided action” bucket)
3. RAPPOR of launching app name (if available, otherwise “unknown”)
4. Count of background tab notification opens
5. Count of download notification opens (or a new bucket in an existing histogram if this is counted already)
6. Histogram of count of tabs queued behind the notification (at time of tab open, including the one just opened i.e. starting at 1)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4960963e7c323fdf88690697322175348af996f1

commit 4960963e7c323fdf88690697322175348af996f1
Author: Lei Tian <ltian@google.com>
Date: Thu Oct 26 22:42:12 2017

Add rappor metrics for measuring launching app name of Browser Actions.

Add the rappor metrics to measure the launching app name who requests to
show the Browser Actoins context menu. Follow what CCT does to have two
metrics that one for all apps while the others for apps excluding AGSA.

Bug:  776967 
Change-Id: I3cfd2385d51af42e88cdba593e3281a7e7190e21
Reviewed-on: https://chromium-review.googlesource.com/734661
Commit-Queue: Lei Tian <ltian@google.com>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511992}
[modify] https://crrev.com/4960963e7c323fdf88690697322175348af996f1/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
[modify] https://crrev.com/4960963e7c323fdf88690697322175348af996f1/tools/metrics/rappor/rappor.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aae9f7531d7b0facce2256d36284d6d877fc1c20

commit aae9f7531d7b0facce2256d36284d6d877fc1c20
Author: Lei Tian <ltian@google.com>
Date: Fri Oct 27 00:28:04 2017

Add User Actions for Browser Actions menu is opened.

Add User Actions metric to record the Browser Actions menu opened in
Chrome.

Bug:  776967 
Change-Id: I4f91d141c65fbdd6b1c19453912b1c461ba4820c
Reviewed-on: https://chromium-review.googlesource.com/731670
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Lei Tian <ltian@google.com>
Cr-Commit-Position: refs/heads/master@{#512038}
[modify] https://crrev.com/aae9f7531d7b0facce2256d36284d6d877fc1c20/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuHelper.java
[modify] https://crrev.com/aae9f7531d7b0facce2256d36284d6d877fc1c20/tools/metrics/actions/actions.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07c7037e620a5cc2a4a209a3b9454729ae5591ee

commit 07c7037e620a5cc2a4a209a3b9454729ae5591ee
Author: Lei Tian <ltian@google.com>
Date: Fri Oct 27 23:46:44 2017

Add histogram of selected option for Browser Actions

Add the histogram metric to measure the selected option from a Browser
Actions context menu.

Bug:  776967 
Change-Id: I98787fe1fedcc3d4b7c08e06f9138c8eec57345d
Reviewed-on: https://chromium-review.googlesource.com/731831
Commit-Queue: Lei Tian <ltian@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512352}
[modify] https://crrev.com/07c7037e620a5cc2a4a209a3b9454729ae5591ee/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuHelper.java
[modify] https://crrev.com/07c7037e620a5cc2a4a209a3b9454729ae5591ee/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/07c7037e620a5cc2a4a209a3b9454729ae5591ee/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b6403aea44fcea4f90941dfe3622f6a6dd1e2c3

commit 4b6403aea44fcea4f90941dfe3622f6a6dd1e2c3
Author: Lei Tian <ltian@google.com>
Date: Wed Nov 08 01:10:20 2017

Add the user action metrics of showing and clicking the notification of tab opened in background

Two user action metrics for Browser Actions is added:

BrowserActions.TabOpenedNotificationCreated: measures the number of
notification shown for opening tabs in the background.  Note
shwoing a notification for multi-tabs is not counted as a new one. And
if Chrome gets killed, then Browser Actoins opens a tab in background,
new notification is still for multi-tabs. Only ChromeTabbedActivity
start resets the state.

BrowserActions.TabOpenedNotificationClicked: measures users actions of
clicking the notification of opening tab in background.

Bug:  776967 
Change-Id: I901654870deceefa20ba89469d4852a079eadb6e
Reviewed-on: https://chromium-review.googlesource.com/750231
Commit-Queue: Lei Tian <ltian@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514693}
[modify] https://crrev.com/4b6403aea44fcea4f90941dfe3622f6a6dd1e2c3/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/4b6403aea44fcea4f90941dfe3622f6a6dd1e2c3/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsService.java
[modify] https://crrev.com/4b6403aea44fcea4f90941dfe3622f6a6dd1e2c3/tools/metrics/actions/actions.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/328eaad2c45bae5c0cb5653d38a11442f886ab2e

commit 328eaad2c45bae5c0cb5653d38a11442f886ab2e
Author: Lei Tian <ltian@chromium.org>
Date: Thu Nov 09 21:33:00 2017

Add histogram metric to measure number of tabs opened in the background

Add a histogram metric to measure the number of tabs opened in the
background when users tap the "Open in new Chrome tab" option from
Browser Actions context menu. The number includes the new tab just
created from the tap.

Also clean unnecessary code from BrowserActionsService.

Bug:  776967 
Change-Id: I214a3b6e7833c28ce691424d84912b9a3c874e25
Reviewed-on: https://chromium-review.googlesource.com/759302
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Lei Tian <ltian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515297}
[modify] https://crrev.com/328eaad2c45bae5c0cb5653d38a11442f886ab2e/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/328eaad2c45bae5c0cb5653d38a11442f886ab2e/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsService.java
[modify] https://crrev.com/328eaad2c45bae5c0cb5653d38a11442f886ab2e/tools/metrics/histograms/histograms.xml

Comment 6 by ltian@chromium.org, Feb 2 2018

Status: Fixed (was: Assigned)

Sign in to add a comment