Issue metadata
Sign in to add a comment
|
Image decoding regression |
||||||||||||||||||||||||
Issue descriptionThere are a number of bot reporting regressions in: smoothness.gpu_rasterization_and_decoding.image_decoding_cases/avg_surface_fps and smoothness.image_decoding_cases/avg_surface_fps For example, this one is showing a 245% regression: https://chromeperf.appspot.com/report?sid=0ae9996f48be2f2b84415d6818a1370ecb1797be0138942372cdad0325bf1fb6&rev=509975
,
Oct 20 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8965180713798035952
,
Oct 20 2017
,
Oct 20 2017
Khushal found it. (Thank you) It turns out this is fine and expected. Certain things can cause a veto of checker-images. This would force the image decoding to be synchronous and thus impact Blink's FPS. One of the test cases changes the src[1], which results in using synchronous decoding. [1] https://cs.chromium.org/chromium/src/tools/perf/page_sets/image_decoding_cases/yuv_decoding.html So when we correctly included vetoes, we expected a regression in the vetoed cases.
,
Oct 22 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Vladimir Levin Commit : 9167e1c4eb3a1b6d094399e35efe427185303428 Date : Wed Oct 18 21:28:24 2017 Subject: cc: Plumb decoding mode state to checker image tracker. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : smoothness.image_decoding_cases Metric : mean_frame_time/mean_frame_time Change : 57.41% | 19.12 -> 30.0973333333 Revision Result N chromium@509828 19.12 +- 3.6661 6 good chromium@509863 18.5375 +- 0.579391 6 good chromium@509872 18.434 +- 0.621802 6 good chromium@509876 18.548 +- 0.596361 6 good chromium@509878 18.4893 +- 0.455512 6 good chromium@509879 31.5325 +- 0.44701 6 bad <-- chromium@509880 31.5537 +- 0.37241 6 bad chromium@509897 30.0973 +- 0.604906 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests smoothness.image_decoding_cases More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8965180713798035952 For feedback, file a bug with component Speed>Bisection |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 20 2017