cros tryjob: support applying gerrit patches to Chromium browser repos |
||||||
Issue descriptionwhen Chromium migrated from rietveld to GoB, we didn't update our patching logic to match, and no one has noticed/asked :) we might have to restore part of this revert (PatchChromeStage): https://chromium-review.googlesource.com/612822 i guess we'll need to add a dedicated option again (-G?) since, from a Gerrit CL # alone, there's no real way to determine where we should apply that patch. Chromium & Chromium OS checkout many of the same repos.
,
Oct 20 2017
,
Oct 20 2017
My use case is modifying some telemetry benchmarks from chrome os, which are specified in chromium (src/tools/perf/...). Without the ability of patching chromium, it's not possible to test with trybots.
,
Oct 20 2017
from chrome os -> for chrome os
,
Oct 20 2017
Aviv, I ripped out the Reitveld support as unused, but even it it was still in place it wouldn't help here.
,
Oct 26 2017
+stevenjb can you help assess the priority or impact here?
,
Oct 26 2017
Could this be what is preventing my patches for issue 732579 from succeeding? (Specifically, the pfq master needs to be able to modify CHROMEOS_LKGM in the chromium repo). If so, then I would say it is very important... otherwise I don't know.
,
Oct 26 2017
doubtful. this is for devs to run remote tryjobs with uncommitted patches in gerrit or local repos.
,
Jun 8 2018
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be archived. Thank you.
,
Dec 28
Can this be prioritized? We (toolchain team) often have chrome patches that we want to test but right now the only way is an hacky epatch in chrome ebuild.
,
Dec 29
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dgarr...@chromium.org
, Oct 20 2017