Implement Explicit Tryjob Build Configs |
|||||
Issue descriptionTo simplify CIDB and build_group handling for tryjobs, implement the proposal go/cros-explicit-tryjob-build-configs.
,
Oct 21 2017
A stack of CLs is uploaded for review. Notes about what comes next: cros tryjob --list is updated to show tryjob configs. cros tryjob --production --list is updated to show non-tryjob configs. cros tryjob refuses to schedule a non tryjob build config. cbuildbot uses prod CIDB if either --buildbot or --remote-trybot are set. cbuildbot checks builder hostname if either --buildbot or --remote-trybot is set. Start setting build_group tryjob for other test configs Start filling in build_group for production configs. Enable test to force build_group for all configs. File bugs about remaining command line options and behaviors to cleanup.... someday.
,
Oct 21 2017
Oh... also, remove the Override config method call when --remote-trybot is set.
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/370839fe525e79fe84ceb71147661953e632fabd commit 370839fe525e79fe84ceb71147661953e632fabd Author: Don Garrett <dgarrett@google.com> Date: Mon Oct 30 17:45:00 2017 config_lib: Add 'debug' build config value. This (so far unused) config value will force builds to run as if --debug had been set on the command line. BUG= chromium:776955 TEST=run_tests Change-Id: I07bfef39bdc46b54dfb72d41ef47e0f9de1f9ac0 Reviewed-on: https://chromium-review.googlesource.com/731475 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/370839fe525e79fe84ceb71147661953e632fabd/cbuildbot/config_dump.json [modify] https://crrev.com/370839fe525e79fe84ceb71147661953e632fabd/scripts/cbuildbot.py [modify] https://crrev.com/370839fe525e79fe84ceb71147661953e632fabd/lib/config_lib.py
,
Oct 30 2017
,
Oct 30 2017
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/41041e639c560138c9e6f50060101795e8f25031 commit 41041e639c560138c9e6f50060101795e8f25031 Author: Don Garrett <dgarrett@google.com> Date: Thu Nov 02 07:12:48 2017 config_lib: Create 'display_label' config setting. Create the new setting, and create constants to define the legal values for it, but don't yet do anything with it. BUG= chromium:776955 TEST=run_tests Change-Id: Id76ea1d8aa8ea1e9ed863341a9b97c27f5c260cc Reviewed-on: https://chromium-review.googlesource.com/731827 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/41041e639c560138c9e6f50060101795e8f25031/cbuildbot/config_dump.json [modify] https://crrev.com/41041e639c560138c9e6f50060101795e8f25031/lib/config_lib_unittest.py [modify] https://crrev.com/41041e639c560138c9e6f50060101795e8f25031/lib/config_lib.py [modify] https://crrev.com/41041e639c560138c9e6f50060101795e8f25031/cbuildbot/chromeos_config_unittest.py [modify] https://crrev.com/41041e639c560138c9e6f50060101795e8f25031/cbuildbot/chromeos_config.py
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/a4a723552b4358ffef73b6aa4283bf075196fc47 commit a4a723552b4358ffef73b6aa4283bf075196fc47 Author: Don Garrett <dgarrett@google.com> Date: Thu Nov 02 07:12:48 2017 cros_tryjob: Use 'display_label' when scheduling remote tryjobs. Use the new build config value (if possible) as a buildbucket tags when scheduling tryjobs. Also, rename build_group -> display_label in remote_try library to match the update build config value name. BUG= chromium:776955 TEST=run_tests Change-Id: I80260609015630169fef3d39a007679386b2c1ac Reviewed-on: https://chromium-review.googlesource.com/731828 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/a4a723552b4358ffef73b6aa4283bf075196fc47/cli/cros/cros_tryjob_unittest.py [modify] https://crrev.com/a4a723552b4358ffef73b6aa4283bf075196fc47/lib/remote_try.py [modify] https://crrev.com/a4a723552b4358ffef73b6aa4283bf075196fc47/lib/remote_try_unittest.py [modify] https://crrev.com/a4a723552b4358ffef73b6aa4283bf075196fc47/cli/cros/cros_tryjob.py
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/bfd5a52fd580183047c4ec376e97a5ae31a27a38 commit bfd5a52fd580183047c4ec376e97a5ae31a27a38 Author: Don Garrett <dgarrett@google.com> Date: Thu Nov 02 07:12:49 2017 chromeos_config: Cleanup tests for tryjob builds. Cleanup two tests that didn't properly work for tryjob variations. This is prep work before creating tryjob mirror configs to isolate related changes. BUG= chromium:776955 TEST=run_tests Change-Id: I2de97ab803414264ab6e6d46e609a9e714c2b23b Reviewed-on: https://chromium-review.googlesource.com/731964 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/bfd5a52fd580183047c4ec376e97a5ae31a27a38/cbuildbot/config_dump.json [modify] https://crrev.com/bfd5a52fd580183047c4ec376e97a5ae31a27a38/cbuildbot/chromeos_config_unittest.py [modify] https://crrev.com/bfd5a52fd580183047c4ec376e97a5ae31a27a38/cbuildbot/chromeos_config.py
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9d0b527394093a0b5d1bba1c6b8d2c4720508ea4 commit 9d0b527394093a0b5d1bba1c6b8d2c4720508ea4 Author: Don Garrett <dgarrett@google.com> Date: Fri Nov 03 01:36:49 2017 chromeos_config: Populating display_label. Populate display_label values for all builders. There are probably mistakes, but it's a reasonable start. BUG= chromium:776955 TEST=run_tests Change-Id: Ib39a5464b62c5c72cc26f866575d1023c9f0c4df Reviewed-on: https://chromium-review.googlesource.com/750069 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Jinjing Liang <jinjingl@google.com> [modify] https://crrev.com/9d0b527394093a0b5d1bba1c6b8d2c4720508ea4/cbuildbot/config_dump.json [modify] https://crrev.com/9d0b527394093a0b5d1bba1c6b8d2c4720508ea4/cli/cros/cros_tryjob_unittest.py [modify] https://crrev.com/9d0b527394093a0b5d1bba1c6b8d2c4720508ea4/lib/config_lib.py [modify] https://crrev.com/9d0b527394093a0b5d1bba1c6b8d2c4720508ea4/cbuildbot/chromeos_config_unittest.py [modify] https://crrev.com/9d0b527394093a0b5d1bba1c6b8d2c4720508ea4/cbuildbot/chromeos_config.py
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/706a605695e2af2a548f6ae5621e6d7e82129880 commit 706a605695e2af2a548f6ae5621e6d7e82129880 Author: Don Garrett <dgarrett@google.com> Date: Wed Nov 08 18:30:34 2017 chromeos_config: Create mirrored tryjob build configs. Create a tryjob variant for most existing build configs. There is more work to do, but this sets the pattern. BUG= chromium:776955 TEST=run_tests Change-Id: Ibac537366b73255c70483bd35f8b573cc6c5968f Reviewed-on: https://chromium-review.googlesource.com/731965 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/706a605695e2af2a548f6ae5621e6d7e82129880/cbuildbot/config_dump.json [modify] https://crrev.com/706a605695e2af2a548f6ae5621e6d7e82129880/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/706a605695e2af2a548f6ae5621e6d7e82129880/lib/config_lib.py [modify] https://crrev.com/706a605695e2af2a548f6ae5621e6d7e82129880/cbuildbot/chromeos_config.py
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/78a0a15feee86753a61d20c95f3ac0929bc14503 commit 78a0a15feee86753a61d20c95f3ac0929bc14503 Author: Don Garrett <dgarrett@google.com> Date: Sat Nov 11 02:45:56 2017 cros tryjob: Update --list for production vs tryjob. Since we how have tryjob vs production specific build configs, display the appropriate lists with "cros tryjob --list". Also removes --all in favor of --production. BUG= chromium:776955 TEST=run_tests Change-Id: If787226d5a1691be32b5c47464693c2d04f01571 Reviewed-on: https://chromium-review.googlesource.com/750070 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/78a0a15feee86753a61d20c95f3ac0929bc14503/cli/cros/cros_tryjob_unittest.py [modify] https://crrev.com/78a0a15feee86753a61d20c95f3ac0929bc14503/lib/config_lib.py [modify] https://crrev.com/78a0a15feee86753a61d20c95f3ac0929bc14503/cli/cros/cros_tryjob.py
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/1b8eabccb50ccbd4eb39ec6394698ef44aab5106 commit 1b8eabccb50ccbd4eb39ec6394698ef44aab5106 Author: Don Garrett <dgarrett@google.com> Date: Mon Nov 13 01:44:29 2017 cros tryjob: Enforce tryjob safe configs. Don't let people schedule tryjobs for configs that aren't safe to run as tryjobs. A follow up CL will enforce the same thing in cbuildbot. BUG= chromium:776955 TEST=run_tests + manual attempts to schedule various combinations. Change-Id: Ia2ec246d0d97fd951d6bc78b7e220bd97f2fa868 Reviewed-on: https://chromium-review.googlesource.com/751799 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/1b8eabccb50ccbd4eb39ec6394698ef44aab5106/cli/cros/cros_tryjob_unittest.py [modify] https://crrev.com/1b8eabccb50ccbd4eb39ec6394698ef44aab5106/cli/cros/cros_tryjob.py
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/02d2f580bff1d2a7e5b4337894e17779d5cb25ab commit 02d2f580bff1d2a7e5b4337894e17779d5cb25ab Author: Don Garrett <dgarrett@google.com> Date: Mon Nov 13 01:44:29 2017 cbuildbot: Enforce tryjob safe configs. Require either --buildbot or --debug to run a non-tryjob safe build config. This ensures that production build configs can't be launched in an unsafe way by either old versions of cros tryjob, or on branches. BUG= chromium:776955 TEST=run_tests Change-Id: I83a97b662044ea0ee79f56114b5807d17471eab6 Reviewed-on: https://chromium-review.googlesource.com/759222 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/02d2f580bff1d2a7e5b4337894e17779d5cb25ab/scripts/cbuildbot.py
,
Nov 16 2017
The configs exist and are enforced. But we haven't yet made all tryjob configs safe to run against Prod CIDB, and so haven't yet switched them to use Prod CIDB.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/12baece1ed134774492534974da870cc30f2ec65 commit 12baece1ed134774492534974da870cc30f2ec65 Author: Don Garrett <dgarrett@google.com> Date: Fri Nov 17 10:00:34 2017 config_lib: Remove OverrideConfigForTrybot. We can stop dynamically updating configs, because we are already generate tryjob specific configs. BUG= chromium:776955 TEST=run_tests Change-Id: Icc70573aa5282994e9b0de96b378b003cd58e973 Reviewed-on: https://chromium-review.googlesource.com/773568 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/12baece1ed134774492534974da870cc30f2ec65/lib/config_lib_unittest.py [modify] https://crrev.com/12baece1ed134774492534974da870cc30f2ec65/scripts/cbuildbot.py [modify] https://crrev.com/12baece1ed134774492534974da870cc30f2ec65/lib/config_lib.py [modify] https://crrev.com/12baece1ed134774492534974da870cc30f2ec65/cbuildbot/chromeos_config_unittest.py [modify] https://crrev.com/12baece1ed134774492534974da870cc30f2ec65/cbuildbot/stages/generic_stages_unittest.py
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d4d32120a7a08ca5f0cc3beb6e9cd3c7dc7f640d commit d4d32120a7a08ca5f0cc3beb6e9cd3c7dc7f640d Author: Don Garrett <dgarrett@chromium.org> Date: Mon Nov 20 22:14:39 2017 Revert "config_lib: Remove OverrideConfigForTrybot." This reverts commit 12baece1ed134774492534974da870cc30f2ec65. Reason for revert: This CL exposed a bug in my code to stop people from running production build configs for testing purposes. Those tryjobs (without this CL) were doing real stuff like trying to sign the results, which is bad, and which also broke real release builds. Reverting, for now. I'll fix the other bug, and when I'm confident in the fix, reland this. BUG=chromium:786685 TEST=None Original change's description: > config_lib: Remove OverrideConfigForTrybot. > > We can stop dynamically updating configs, because we are already > generate tryjob specific configs. > > BUG= chromium:776955 > TEST=run_tests > > Change-Id: Icc70573aa5282994e9b0de96b378b003cd58e973 > Reviewed-on: https://chromium-review.googlesource.com/773568 > Commit-Ready: Don Garrett <dgarrett@chromium.org> > Tested-by: Don Garrett <dgarrett@chromium.org> > Reviewed-by: Don Garrett <dgarrett@chromium.org> Bug: chromium:776955 Change-Id: Ic924d401c85a0f5c611a2a23059383198ed39cb2 Reviewed-on: https://chromium-review.googlesource.com/780261 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/d4d32120a7a08ca5f0cc3beb6e9cd3c7dc7f640d/lib/config_lib_unittest.py [modify] https://crrev.com/d4d32120a7a08ca5f0cc3beb6e9cd3c7dc7f640d/scripts/cbuildbot.py [modify] https://crrev.com/d4d32120a7a08ca5f0cc3beb6e9cd3c7dc7f640d/lib/config_lib.py [modify] https://crrev.com/d4d32120a7a08ca5f0cc3beb6e9cd3c7dc7f640d/cbuildbot/chromeos_config_unittest.py [modify] https://crrev.com/d4d32120a7a08ca5f0cc3beb6e9cd3c7dc7f640d/cbuildbot/stages/generic_stages_unittest.py
,
Dec 13 2017
This is fully launched, though all of the related "safety" changes aren't in place yet.
,
Apr 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/09a52fadcbb00adfae13651926e69c85fd66e788 commit 09a52fadcbb00adfae13651926e69c85fd66e788 Author: Don Garrett <dgarrett@google.com> Date: Sat Apr 14 04:37:30 2018 Reland "config_lib: Remove OverrideConfigForTrybot." This is a reland of 12baece1ed134774492534974da870cc30f2ec65 Original change's description: > config_lib: Remove OverrideConfigForTrybot. > > We can stop dynamically updating configs, because we are already > generate tryjob specific configs. > > BUG= chromium:776955 > TEST=run_tests > > Change-Id: Icc70573aa5282994e9b0de96b378b003cd58e973 > Reviewed-on: https://chromium-review.googlesource.com/773568 > Commit-Ready: Don Garrett <dgarrett@chromium.org> > Tested-by: Don Garrett <dgarrett@chromium.org> > Reviewed-by: Don Garrett <dgarrett@chromium.org> BUG= chromium:776955 TEST=run_tests Change-Id: I760f0de7ebfa9cae24a094dd66369a406b2fc9eb Reviewed-on: https://chromium-review.googlesource.com/780262 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/09a52fadcbb00adfae13651926e69c85fd66e788/lib/config_lib_unittest.py [modify] https://crrev.com/09a52fadcbb00adfae13651926e69c85fd66e788/scripts/cbuildbot.py [modify] https://crrev.com/09a52fadcbb00adfae13651926e69c85fd66e788/lib/config_lib.py [modify] https://crrev.com/09a52fadcbb00adfae13651926e69c85fd66e788/cbuildbot/chromeos_config_unittest.py [modify] https://crrev.com/09a52fadcbb00adfae13651926e69c85fd66e788/cbuildbot/stages/generic_stages_unittest.py
,
Apr 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8957aa60025e2a731d8709694a09ff60a2ada2b0 commit 8957aa60025e2a731d8709694a09ff60a2ada2b0 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Apr 14 11:37:01 2018 Roll src/third_party/chromite/ 2e290076c..c90ccbc26 (8 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/2e290076c8be..c90ccbc26d04 $ git log 2e290076c..c90ccbc26 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 ihf chromeos_config: mark eve-arcnext-chrome-pfq not important. 2018-04-13 cmtice [chromite] Add script to set up env for locally testing fuzz targets. 2018-04-13 marcochen soraka: remove sign type - factory and accessory_rwsig 2017-11-03 dgarrett Reland "config_lib: Remove OverrideConfigForTrybot." 2018-04-13 dgarrett buildbucket_lib: Remove _ah from URLs. 2018-04-13 bmgordon cros lint: Look up pylintrc for all python files 2018-03-14 dgarrett report_stages: Use Logoland build URL for master builder. 2018-03-14 dgarrett validation_pool: Switch to Legoland build links. Created with: roll-dep src/third_party/chromite BUG= chromium:832736 , chromium:776955 ,chromium:None,chromium:None,chromium:821618,chromium:821618 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6c3d1f6d83d8bfb7ea269da65c9f09901668cb37 Reviewed-on: https://chromium-review.googlesource.com/1013395 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550893} [modify] https://crrev.com/8957aa60025e2a731d8709694a09ff60a2ada2b0/DEPS
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8957aa60025e2a731d8709694a09ff60a2ada2b0 commit 8957aa60025e2a731d8709694a09ff60a2ada2b0 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Apr 14 11:37:01 2018 Roll src/third_party/chromite/ 2e290076c..c90ccbc26 (8 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/2e290076c8be..c90ccbc26d04 $ git log 2e290076c..c90ccbc26 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 ihf chromeos_config: mark eve-arcnext-chrome-pfq not important. 2018-04-13 cmtice [chromite] Add script to set up env for locally testing fuzz targets. 2018-04-13 marcochen soraka: remove sign type - factory and accessory_rwsig 2017-11-03 dgarrett Reland "config_lib: Remove OverrideConfigForTrybot." 2018-04-13 dgarrett buildbucket_lib: Remove _ah from URLs. 2018-04-13 bmgordon cros lint: Look up pylintrc for all python files 2018-03-14 dgarrett report_stages: Use Logoland build URL for master builder. 2018-03-14 dgarrett validation_pool: Switch to Legoland build links. Created with: roll-dep src/third_party/chromite BUG= chromium:832736 , chromium:776955 ,chromium:None,chromium:None,chromium:821618,chromium:821618 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6c3d1f6d83d8bfb7ea269da65c9f09901668cb37 Reviewed-on: https://chromium-review.googlesource.com/1013395 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550893} [modify] https://crrev.com/8957aa60025e2a731d8709694a09ff60a2ada2b0/DEPS |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dgarr...@chromium.org
, Oct 20 2017