New issue
Advanced search Search tips

Issue 776952 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
smcgruer@chromium.org
majidvp@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 430155


Participants' hotlists:
Hotlist-AnimationWorklet
Hostlist-AnimationWorklet-OT


Sign in to add a comment

AnimationWorklet - enable ScrollTimeline driven WorkletAnimation (cc/worklet)

Project Member Reported by smcgruer@chromium.org, Oct 20 2017 
This is a tracking bug for enabling ScrollTimeline-driven WorkletAnimations, running only on the compositor.

This will require:

1. Sending data from Blink to cc regarding the ScrollTimeline (target scroller, parameters, etc)
2. Having the scroller be composited.
3. Create the currentTime for an animation using either V8_Local_Time or computing it via the scroller.

Preferably we would also only run ScrollTimeline-based WorkletAnimations when a scroll occurs (and vice versa for non-ScrollTimeline-based animations).

Comment 1 by majidvp@chromium.org, Oct 23 2017

Blocking: 430155
Labels: Hotlist-ThreadedRendering
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31974d24b5de701ff9c290b32e4dd543abec8146

commit 31974d24b5de701ff9c290b32e4dd543abec8146
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Fri Nov 10 19:53:15 2017

Initial implementation of cc::ScrollTimeline

This creates a compositor side concept of a ScrollTimeline, and adds
plumbing so that blink WorkletAnimations created with ScrollTimelines
will create a cc::ScrollTimeline on the compositor side. This means
that scroll-driven AnimationWorklets are now possible.

There are a number of caveats to this initial implementation:
 * We never update the cc::ScrollTimeline, so if the scroller
   changes on the blink side we won't know.
 * We assume that the scroller is composited. If it isn't composited
   during animation play() we will log a warning and fail to start,
   but if it is composited at that time and later becomes non-composited
   we will likely crash.

Bug:  776952 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id0342c62209b387130a69edca4ff3682748bd8a3
Reviewed-on: https://chromium-review.googlesource.com/738437
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: dstockwell <dstockwell@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515645}
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/BUILD.gn
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/animation/BUILD.gn
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/animation/DEPS
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/animation/animation_host.cc
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/animation/animation_host.h
[add] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/animation/scroll_timeline.cc
[add] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/animation/scroll_timeline.h
[add] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/animation/scroll_timeline_unittest.cc
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/animation/worklet_animation_player.cc
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/animation/worklet_animation_player.h
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/animation/worklet_animation_player_unittest.cc
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/test/animation_timelines_test_common.cc
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/test/layer_tree_test.cc
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/trees/layer_tree_mutator.h
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/cc/trees/mutator_host.h
[add] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-expected.html
[add] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline.html
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/core/animation/ScrollTimeline.h
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/core/animation/WorkletAnimationBase.h
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/core/animation/WorkletAnimationController.cpp
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/core/animation/WorkletAnimationController.h
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/modules/animationworklet/Animator.cpp
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/modules/animationworklet/Animator.h
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.cpp
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.h
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp
[modify] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d

commit c21a34ce8871f34c9b414a1df88427e2fb7e0e8d
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Fri Nov 10 21:39:41 2017

Revert "Initial implementation of cc::ScrollTimeline"

This reverts commit 31974d24b5de701ff9c290b32e4dd543abec8146.

Reason for revert: Causes two webkit unit tests to fail on Linux MSAN: AnimationWorkletGlobalScopeTest.ConstructAndAnimate
AnimationWorkletGlobalScopeTest.AnimtionOutput

https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/4257

Original change's description:
> Initial implementation of cc::ScrollTimeline
> 
> This creates a compositor side concept of a ScrollTimeline, and adds
> plumbing so that blink WorkletAnimations created with ScrollTimelines
> will create a cc::ScrollTimeline on the compositor side. This means
> that scroll-driven AnimationWorklets are now possible.
> 
> There are a number of caveats to this initial implementation:
>  * We never update the cc::ScrollTimeline, so if the scroller
>    changes on the blink side we won't know.
>  * We assume that the scroller is composited. If it isn't composited
>    during animation play() we will log a warning and fail to start,
>    but if it is composited at that time and later becomes non-composited
>    we will likely crash.
> 
> Bug:  776952 
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Id0342c62209b387130a69edca4ff3682748bd8a3
> Reviewed-on: https://chromium-review.googlesource.com/738437
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: dstockwell <dstockwell@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515645}

TBR=flackr@chromium.org,ericwilligers@chromium.org,dstockwell@chromium.org,majidvp@chromium.org,smcgruer@chromium.org

Change-Id: Ibc45068df0ec85470acce5717fbd5324401a0296
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  776952 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/764727
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515690}
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/BUILD.gn
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/animation/BUILD.gn
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/animation/DEPS
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/animation/animation_host.cc
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/animation/animation_host.h
[delete] https://crrev.com/0cb5a986bdd0dc43301e6e1ab7b3d67650acb580/cc/animation/scroll_timeline.cc
[delete] https://crrev.com/0cb5a986bdd0dc43301e6e1ab7b3d67650acb580/cc/animation/scroll_timeline.h
[delete] https://crrev.com/0cb5a986bdd0dc43301e6e1ab7b3d67650acb580/cc/animation/scroll_timeline_unittest.cc
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/animation/worklet_animation_player.cc
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/animation/worklet_animation_player.h
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/animation/worklet_animation_player_unittest.cc
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/test/animation_timelines_test_common.cc
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/test/layer_tree_test.cc
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/trees/layer_tree_mutator.h
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/cc/trees/mutator_host.h
[delete] https://crrev.com/0cb5a986bdd0dc43301e6e1ab7b3d67650acb580/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-expected.html
[delete] https://crrev.com/0cb5a986bdd0dc43301e6e1ab7b3d67650acb580/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline.html
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/core/animation/ScrollTimeline.h
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/core/animation/WorkletAnimationBase.h
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/core/animation/WorkletAnimationController.cpp
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/core/animation/WorkletAnimationController.h
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/modules/animationworklet/Animator.cpp
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/modules/animationworklet/Animator.h
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.cpp
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.h
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp
[modify] https://crrev.com/c21a34ce8871f34c9b414a1df88427e2fb7e0e8d/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h

Comment 5 by smcgruer@chromium.org, Nov 10 2017 

Huh, that's interesting. Looking at the tests that failed, they don't fully initialize their CompositorMutatorInputState::AnimationState:

RunAnimateOutputTestOnWorklet:

    CompositorMutatorInputState::AnimationState test_animation_state;
    test_animation_state.animation_player_id = 1;
    test_animation_state.name = "test";
    state.animations = {test_animation_state};

They don't set the current_time field, so it makes sense that it later gets used uninitialized.

What I don't get is that this is true before my CL as well as after. The only things that changed are:

i. The type of current_time changed from a base::TimeTicks to a double, and
ii. How it is used changed slightly; it was previously used to initialize another variable and then passed to a function whereas after my CL it is just passed straight to the function call.


Eh, either way I'll fix the test and re-land the patch.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd49479cf34e386b7ad3b8d3bad794eee497bd06

commit bd49479cf34e386b7ad3b8d3bad794eee497bd06
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Mon Nov 13 18:16:49 2017

Reland "Initial implementation of cc::ScrollTimeline"

This is a reland of 31974d24b5de701ff9c290b32e4dd543abec8146
Original change's description:
> Initial implementation of cc::ScrollTimeline
> 
> This creates a compositor side concept of a ScrollTimeline, and adds
> plumbing so that blink WorkletAnimations created with ScrollTimelines
> will create a cc::ScrollTimeline on the compositor side. This means
> that scroll-driven AnimationWorklets are now possible.
> 
> There are a number of caveats to this initial implementation:
>  * We never update the cc::ScrollTimeline, so if the scroller
>    changes on the blink side we won't know.
>  * We assume that the scroller is composited. If it isn't composited
>    during animation play() we will log a warning and fail to start,
>    but if it is composited at that time and later becomes non-composited
>    we will likely crash.
> 
> Bug:  776952 
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Id0342c62209b387130a69edca4ff3682748bd8a3
> Reviewed-on: https://chromium-review.googlesource.com/738437
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: dstockwell <dstockwell@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515645}

Bug:  776952 
Change-Id: I372d8fd48c62a63b5c6b10688d3829e4ac2c3be1
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/764578
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: dstockwell <dstockwell@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515985}
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/BUILD.gn
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/animation/BUILD.gn
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/animation/DEPS
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/animation/animation_host.cc
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/animation/animation_host.h
[add] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/animation/scroll_timeline.cc
[add] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/animation/scroll_timeline.h
[add] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/animation/scroll_timeline_unittest.cc
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/animation/worklet_animation_player.cc
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/animation/worklet_animation_player.h
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/animation/worklet_animation_player_unittest.cc
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/test/animation_timelines_test_common.cc
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/test/layer_tree_test.cc
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/trees/layer_tree_mutator.h
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/cc/trees/mutator_host.h
[add] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-expected.html
[add] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline.html
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/core/animation/ScrollTimeline.h
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/core/animation/WorkletAnimationBase.h
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/core/animation/WorkletAnimationController.cpp
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/core/animation/WorkletAnimationController.h
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScopeTest.cpp
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/modules/animationworklet/Animator.cpp
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/modules/animationworklet/Animator.h
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.cpp
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.h
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp
[modify] https://crrev.com/bd49479cf34e386b7ad3b8d3bad794eee497bd06/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ffefffdd6ba0311f55a2e490bf611b80786d8ce

commit 6ffefffdd6ba0311f55a2e490bf611b80786d8ce
Author: Majid Valipour <majidvp@chromium.org>
Date: Fri Feb 23 20:56:52 2018

[animation-worklet] Tick Mutator only when animation input changes

Previously we send an update to AnimationWorklet every time there was a ticking
animation present. This was particularly bad for scroll-linked animations which
may not need to be ticked every frame but only when their input scroller offset
has changed.

This CL introduces a simple optimization where we only animate if there is at
least one ticking animation whose input has changed.

Also we no longer take mutator_ into account in NeedsTickAnimations()
because mutator's need for ticking is already captured by existence of ticking
worklet animation players.

Bug:  776952 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iab0b81a10a925b70fa676c22cd6d0888bf0a7614
Reviewed-on: https://chromium-review.googlesource.com/927405
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538893}
[modify] https://crrev.com/6ffefffdd6ba0311f55a2e490bf611b80786d8ce/cc/animation/animation_host.cc
[modify] https://crrev.com/6ffefffdd6ba0311f55a2e490bf611b80786d8ce/cc/animation/animation_host.h
[modify] https://crrev.com/6ffefffdd6ba0311f55a2e490bf611b80786d8ce/cc/animation/worklet_animation.cc
[modify] https://crrev.com/6ffefffdd6ba0311f55a2e490bf611b80786d8ce/cc/animation/worklet_animation.h
[modify] https://crrev.com/6ffefffdd6ba0311f55a2e490bf611b80786d8ce/cc/animation/worklet_animation_unittest.cc

Comment 8 by smcgruer@chromium.org, Feb 27 2018

Cc: smcgruer@chromium.org
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Started)

Comment 9 by majidvp@chromium.org, Mar 5 2018

Status: Fixed (was: Available)
This is all done except promoting the scroller which we have decided not to do. See https://bugs.chromium.org/p/chromium/issues/detail?id=776533#c2
►

Sign in to add a comment