New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 776942 link

Starred by 1 user
Status: Duplicate
Merged: issue 360221
Owner: ----
Closed: Oct 2017
Cc:
fmea...@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Need presubmit for updating histograms.xml

Project Member Reported by panicker@chromium.org, Oct 20 2017 
I've managed to submit multiple CLs while forgetting to update histograms.xml (and missed by multiple / different reviewers also)
https://chromium-review.googlesource.com/c/chromium/src/+/661860
https://chromium-review.googlesource.com/c/chromium/src/+/668140
A side effect of this is failing to have something from metrics team review the UMA.

Seems like there should be a presubmit to catch this situation?

Comment 1 by isherman@chromium.org, Oct 20 2017

Cc: -isherman@chromium.org
Status: Available (was: Untriaged)
Agreed that it would be nice to have a presubmit.  I think the main reason that we don't have one is that it's not immediately obvious how to write a good one.

Comment 2 by panicker@google.com, Oct 20 2017 

Alternatively maybe don't show the histogram in chrome://histograms unless the xml is updated, as a reminder to code authors (while testing locally)?

Comment 3 by isherman@chromium.org, Oct 20 2017

Mergedinto: 360221
Status: Duplicate (was: Available)
I think that most developers don't use chrome://histograms, so there would be relatively little coverage gain IMO.  Plus, we'd then need to special-case locally recorded (non-uploaded) histograms, which seems like unnecessary work.

Turns out there's already a bug on file for this, duping into that one.
►

Sign in to add a comment