New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776920 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ICU's SmallDigitFormatter uses 48kb of .rodata for no good reason

Project Member Reported by agrieve@chromium.org, Oct 20 2017

Issue description

https://cs.chromium.org/search/?q=SmallIntFormatter&type=cs

>>> Print(size_info1.symbols.WhereNameMatches('^gDigit'))
Showing 2 symbols (2 unique) with total pss: 49154 bytes
Histogram of symbols based on PSS:
    [16384,32768): 1   [32768,65536): 1
.rodata=48.0kb     total=48.0kb
Number of unique paths: 1

Section Legend: r=.rodata
Index | Running Total | Section@Address | PSS | Path
------------------------------------------------------------
0)      16386 (33.3%) r@0x28bef7c  16386          third_party/icu/source/i18n/smallintformatter.cpp
             gDigitCount
1)      49154 (100.0%) r@0x28c2f7c  32768          third_party/icu/source/i18n/smallintformatter.cpp
             gDigits


I highly doubt that formatting small positive integers within translations is worth optimizing to this extent.
 
Owner: digit@chromium.org
Status: Fixed (was: Available)
Thanks digit!
Fixed here: 2e0c90b4c98f3fa7d5b7a71cf4058afa589cb6e0

Sign in to add a comment