New issue
Advanced search Search tips

Issue 776909 link

Starred by 2 users
Status: Fixed
Owner:
mek@chromium.org
Closed: Oct 2017
Cc:
mek@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 611935
issue 776166



Sign in to add a comment

[mojo-blobs] Fix how BlobBytesProvider keeps process alive

Project Member Reported by mek@chromium.org, Oct 20 2017 
Two issues with the current code:
- it calls SuddenTerminationChanged on the wrong thread (the method can only be called from the main thread)
- it doesn't do the equivalent of AddRefProcess/ReleaseProcess
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2ef4231e001ca403587ff946992ffc1ff50cf4a

commit e2ef4231e001ca403587ff946992ffc1ff50cf4a
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Mon Oct 23 20:08:51 2017

Fix process lifetime management in BlobBytesProvider.

This both fixes BlobBytesProvider incorrectly calling
SuddenTerminationChanged from multiple threads, and adds calls to
AddRefProcess/ReleaseProcess.

The latter of those requires actually exposing that functionality to
blink, which is done through blink::Platform methods.

Bug:  776909 
Change-Id: I5f61636f6907cb11f7e29d0cdde3c8a39a483996
Reviewed-on: https://chromium-review.googlesource.com/731511
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510890}
[modify] https://crrev.com/e2ef4231e001ca403587ff946992ffc1ff50cf4a/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/e2ef4231e001ca403587ff946992ffc1ff50cf4a/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/e2ef4231e001ca403587ff946992ffc1ff50cf4a/third_party/WebKit/Source/platform/blob/BlobBytesProvider.cpp
[modify] https://crrev.com/e2ef4231e001ca403587ff946992ffc1ff50cf4a/third_party/WebKit/public/platform/Platform.h

Comment 2 by mek@chromium.org, Oct 23 2017

Status: Fixed (was: Assigned)

Comment 3 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 4 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 5 by laforge@google.com, Nov 8 2017

Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611935

Comment 6 by mek@chromium.org, Dec 5 2017

Cc: mek@chromium.org
 Issue 740590  has been merged into this issue.
►

Sign in to add a comment