New issue
Advanced search Search tips

Issue 776901 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Settings: Non CDMA Cellular should always show SIM info

Project Member Reported by steve...@chromium.org, Oct 20 2017

Issue description

Currently the Cellular SIM info does not always display for LTE modems.

We need to always display the UI so that the SIM can be locked by the user if desired.

 
Labels: -Pri-2 -M-64 M-63 Pri-1
Summary: Settings: Non CDMA Cellular should always show SIM info (was: Settings: Non CDMA Cellular should always sjow SIM info)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff9a7b68e03c099d030c5b242441b03d2965efba

commit ff9a7b68e03c099d030c5b242441b03d2965efba
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Sat Oct 21 03:27:58 2017

Settings: Network: Fix Cellular siminfo

Bug:  776901 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id07479771abd6bf1eacfdc0abc13bbcfb12b6d25
Reviewed-on: https://chromium-review.googlesource.com/730849
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510653}
[modify] https://crrev.com/ff9a7b68e03c099d030c5b242441b03d2965efba/chrome/browser/resources/settings/internet_page/internet_detail_page.js

Status: Fixed (was: Started)
Labels: Merge-Request-63
Components: UI>Settings OS>Systems>Mobile
Labels: -Type-Bug Type-Bug-Regression
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 24 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 30 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 30 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/768d0ee39d542e05fcd661782bd8113738868898

commit 768d0ee39d542e05fcd661782bd8113738868898
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Oct 30 16:40:53 2017

Settings: Network: Fix Cellular siminfo

TBR=stevenjb@chromium.org

(cherry picked from commit ff9a7b68e03c099d030c5b242441b03d2965efba)

Bug:  776901 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id07479771abd6bf1eacfdc0abc13bbcfb12b6d25
Reviewed-on: https://chromium-review.googlesource.com/730849
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510653}
Reviewed-on: https://chromium-review.googlesource.com/744182
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#292}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/768d0ee39d542e05fcd661782bd8113738868898/chrome/browser/resources/settings/internet_page/internet_detail_page.js

Sign in to add a comment