New issue
Advanced search Search tips

Issue 776888 link

Starred by 1 user
Status: Fixed
Owner:
sahel@chromium.org
Closed: Oct 2017
Cc:
dgozman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Devtools: wheel phase not set properly when wheel scroll latching and async wheel events enabled.

Project Member Reported by sahel@chromium.org, Oct 20 2017 
Chrome Version: 64.0.3245.0
OS: Android

What steps will reproduce the problem?
(1)Make sure TouchpadAndWheelScrollLatching and AsyncWheelEvents are enabled.
(2)Navigate to any scrollable webpage.
(3)inspect the page using remote dev tools, wheel scroll on the remote inspection window.

What is the expected result?
Scroll normally.

What happens instead?
https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/mouse_wheel_event_queue.cc?rcl=739de36a178fecbb92f4aebe4ee478cbacb9e212&l=283
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f7a3170a7a73eb186e54edd8bd3edd22416c2ac

commit 7f7a3170a7a73eb186e54edd8bd3edd22416c2ac
Author: Sahel Sharify <sahel@chromium.org>
Date: Tue Oct 24 16:41:57 2017

EmulateTouchFromMouseEvent sets phase for wheel events when latching on.

In https://chromium-review.googlesource.com/619832 DispatchMouseEvent
from protocol/input_handler.cc adds phase info to wheel events when
wheel scroll latching is enabled. This cl adds phase info to wheel
events that are forwarded from EmulateTouchFromMouseEvent.

To test this I changed emulateTouchFromMouseEvent.js to cover mousewheel
events as well; Without the changes from this cl the modified test fails
while handling the forwarded wheel event.

Bug:  776888 , 526463
Test: inspector-protocol/input/emulateTouchFromMouseEvent.js
Change-Id: I6f86e75b841ba2fb34dfa4322488945e49268960
Reviewed-on: https://chromium-review.googlesource.com/733608
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511173}
[modify] https://crrev.com/7f7a3170a7a73eb186e54edd8bd3edd22416c2ac/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/7f7a3170a7a73eb186e54edd8bd3edd22416c2ac/third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.js

Comment 2 by sahel@chromium.org, Oct 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment