New issue
Advanced search Search tips

Issue 776879 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 767116
issue 589943



Sign in to add a comment

"Download complete" checkmark 1px too low

Project Member Reported by bettes@chromium.org, Oct 20 2017

Issue description

Can we tweak the y-position of the checkmark to be 1px higher? See gif of today's implementation compared with the proposed. 


 
download-check.gif
685 KB View Download

Comment 1 by sdy@chromium.org, Nov 4 2017

Status: Started (was: Assigned)
CL: https://chromium-review.googlesource.com/c/chromium/src/+/754541
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27336870b5e8e0ed0979121522faadadf4f658c9

commit 27336870b5e8e0ed0979121522faadadf4f658c9
Author: Sidney San Martín <sdy@chromium.org>
Date: Mon Nov 06 14:59:19 2017

Move download complete checkmark up by 1px.

Bug:  776879 
Change-Id: I7917c62eadb9b187d9ea32455c8c72a1c6752166
Reviewed-on: https://chromium-review.googlesource.com/754541
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514130}
[modify] https://crrev.com/27336870b5e8e0ed0979121522faadadf4f658c9/chrome/browser/ui/cocoa/download/md_download_item_progress_indicator.mm

Comment 3 by sdy@chromium.org, Nov 6 2017

Status: Fixed (was: Started)
Labels: TE-Verified-M64 TE-Verified-64.0.3261.0
Verified the fix on Mac 10.12.6 using Chrome version #64.0.3261.0 as per the comment #0.
Attaching screen cast and screen shot for reference.
Observed that download complete checkmark is moved up by 1 px.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!

776879.webm
5.5 MB View Download
Screen Shot 2017-11-07 at 3.25.52 PM.png
12.1 KB View Download

Sign in to add a comment