New issue
Advanced search Search tips

Issue 776866 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-XR

Blocking:
issue 773882



Sign in to add a comment

Move vr service registration callback to a cross-platform location

Project Member Reported by billorr@chromium.org, Oct 20 2017

Issue description

We have a callback function to create the VRServiceImpl, so it can live in chrome\browser, but can be consumed in content.  This callback is set on Android when native libraries are loaded, but not currently set on desktop.

 
Components: Internals>VR
Labels: Proj-VR
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b94152be59168ff497da3212bfde0fb0d5ca2b34

commit b94152be59168ff497da3212bfde0fb0d5ca2b34
Author: Bill Orr <billorr@chromium.org>
Date: Mon Oct 23 19:14:10 2017

Move WebVRServiceCallback registration to a cross-platform location

The WebVR service is registered through a callback function as a level
of indirection so that it can be implemented in chrome/browser, but
consumed by component.  This callback function needs to be set early
during process startup.

Desktop WebVR support is starting to land (behind a flag) so we need to
move registration from the current Android-specific location to
somewhere cross-platform.

BUG= 776866 

Change-Id: I363434259cbf21105e6be0cbdc308c0e6f3d8e91
Reviewed-on: https://chromium-review.googlesource.com/730488
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510869}
[modify] https://crrev.com/b94152be59168ff497da3212bfde0fb0d5ca2b34/chrome/browser/BUILD.gn
[modify] https://crrev.com/b94152be59168ff497da3212bfde0fb0d5ca2b34/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/b94152be59168ff497da3212bfde0fb0d5ca2b34/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/b94152be59168ff497da3212bfde0fb0d5ca2b34/chrome/browser/vr/BUILD.gn

Status: Available (was: Untriaged)
Blocking: 773882
Labels: VR-Desktop
Owner: billorr@chromium.org
Status: Assigned (was: Available)
billorr: Is this fixed now? 
Status: Fixed (was: Assigned)
This is fixed.
Labels: M-64 Test-Complete
Components: Internals>XR

Sign in to add a comment