Move vr service registration callback to a cross-platform location |
||||||
Issue descriptionWe have a callback function to create the VRServiceImpl, so it can live in chrome\browser, but can be consumed in content. This callback is set on Android when native libraries are loaded, but not currently set on desktop.
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b94152be59168ff497da3212bfde0fb0d5ca2b34 commit b94152be59168ff497da3212bfde0fb0d5ca2b34 Author: Bill Orr <billorr@chromium.org> Date: Mon Oct 23 19:14:10 2017 Move WebVRServiceCallback registration to a cross-platform location The WebVR service is registered through a callback function as a level of indirection so that it can be implemented in chrome/browser, but consumed by component. This callback function needs to be set early during process startup. Desktop WebVR support is starting to land (behind a flag) so we need to move registration from the current Android-specific location to somewhere cross-platform. BUG= 776866 Change-Id: I363434259cbf21105e6be0cbdc308c0e6f3d8e91 Reviewed-on: https://chromium-review.googlesource.com/730488 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#510869} [modify] https://crrev.com/b94152be59168ff497da3212bfde0fb0d5ca2b34/chrome/browser/BUILD.gn [modify] https://crrev.com/b94152be59168ff497da3212bfde0fb0d5ca2b34/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/b94152be59168ff497da3212bfde0fb0d5ca2b34/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/b94152be59168ff497da3212bfde0fb0d5ca2b34/chrome/browser/vr/BUILD.gn
,
Nov 13 2017
,
Nov 13 2017
billorr: Is this fixed now?
,
Nov 21 2017
This is fixed.
,
Feb 7 2018
,
Jul 4
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by billorr@chromium.org
, Oct 20 2017Labels: Proj-VR