Touch selection handles in embedded PDF are in wrong place after mainframe scroll. |
|||
Issue descriptionChrome Version: tip-of-tree (r510143) OS: Win, CrOS, Linux Pre-req: a desktop system with a touch screen. What steps will reproduce the problem? (1) Open a paged with an embedded PDF, such as https://msu.edu/~urban/sme865/resources/embedded_pdf.html (2) Longpress to select some text in the PDF. (3) Scroll the mainframe. What is the expected result? Longpress should highlight the text, and quickmenu + touch-selection handles should appear. During the scroll the handles should disappear, but at the end of the scroll they should reappear correctly positioned around the selection. What happens instead? Longpress does highlight the text, and quickmenu + touch-selection handles do appear. During the scroll the handles do disappear, but at the end of the scroll they reappear in the same screen position as before the scroll, and are not correctly positioned w.r.t. the text selection.
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa487d2858558b5b9e7c910ae309341279240a57 commit fa487d2858558b5b9e7c910ae309341279240a57 Author: W. James MacLean <wjmaclean@chromium.org> Date: Mon Oct 23 16:30:10 2017 Implement DidScroll() for PDFWebContentsHelper. TouchSelectionControllerClient::DidScroll() is how subframes are given the chance after a mainframe scroll to update selection coordinates for TouchSelection editing handles/quickmenu. This CL implements this for PDFWebContentsHelper so that handles/quickmenu display correctly after an embedded PDF's mainframe is scrolled. Bug: 776839 Change-Id: Ifb9c6ca28e1f17653cb7cba1619575ea44faec6e Reviewed-on: https://chromium-review.googlesource.com/730412 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#510817} [modify] https://crrev.com/fa487d2858558b5b9e7c910ae309341279240a57/components/pdf/browser/pdf_web_contents_helper.cc [modify] https://crrev.com/fa487d2858558b5b9e7c910ae309341279240a57/components/pdf/browser/pdf_web_contents_helper.h
,
Oct 23 2017
,
Oct 24 2017
Tested the issue on Windows 10 - touchscreen laptop using Chrome version 64.0.3248.0 as per the steps mentioned in original comment. Observed that fix is working as expected and no issues are observed. Unable to test this issue on Ubuntu 14.04 as Touchscreen Laptop is not available at TE end. Hence adding 'TE-NeedsTriageFromMTV' for verifying this issue on linux. Thanks... |
|||
►
Sign in to add a comment |
|||
Comment 1 by wjmaclean@chromium.org
, Oct 23 2017