New issue
Advanced search Search tips

Issue 776834 link

Starred by 1 user
Status: Fixed
Owner:
xhw...@chromium.org
Closed: Jan 2018
Cc:
isherman@chromium.org
sande...@chromium.org
jrumm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use suffixes on Media.EME UMAs

Project Member Reported by xhw...@chromium.org, Oct 20 2017 
Currently we have many "duplicate" EME UMAs that could be simplified by using suffixes, e.g.

Media.EME.ClearKey.CreateCdm
Media.EME.Unknown.CreateCdm
Media.EME.Widevine.CreateCdm

Here's suggestions from isherman@:

You should still be able to use histogram_suffixes without renaming the histograms – either via two layers of suffixes, or ordering=prefix.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcd7ae22d6456a74ba68ce4c0354cb82aeb46268

commit bcd7ae22d6456a74ba68ce4c0354cb82aeb46268
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Jan 04 20:43:29 2018

media: Use prefix for Media.EME histogram names

Verified by running the script to print all Media.EME histograms:

./print_histogram_names.py | grep "Media.EME"

For print_histogram_names.py, see change 850545.

BUG= 776834 

Change-Id: I6d95a03b52b66381f3507adc06594e682cbf69a6
Reviewed-on: https://chromium-review.googlesource.com/849705
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527086}
[modify] https://crrev.com/bcd7ae22d6456a74ba68ce4c0354cb82aeb46268/tools/metrics/histograms/histograms.xml

Comment 2 by xhw...@chromium.org, Jan 4 2018

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3310d8ade5e983cf773b8eade016f46b1abf90b8

commit 3310d8ade5e983cf773b8eade016f46b1abf90b8
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Jan 04 23:03:22 2018

metrics: Add script to print all histogram names

This is helpful for people not familiar with metrics internals to
quickly verify the result of a change to *.xml, especially when there's
complicated prefixing involved.

BUG= 776834 

Change-Id: Ie7066699d34a56564ec80f533a6d416dc03cc29d
Reviewed-on: https://chromium-review.googlesource.com/850545
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527132}
[add] https://crrev.com/3310d8ade5e983cf773b8eade016f46b1abf90b8/tools/metrics/histograms/print_histogram_names.py
►

Sign in to add a comment