New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776826 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 776800
issue 776806



Sign in to add a comment

Remove display list code path

Project Member Reported by xlai@chromium.org, Oct 20 2017

Issue description

Remove display list code path
 

Comment 1 by xlai@chromium.org, Oct 20 2017

Blocking: 776800
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74f45cf7fd9cdd165d04d6079cb54a56a1a47075

commit 74f45cf7fd9cdd165d04d6079cb54a56a1a47075
Author: xlai <xlai@chromium.org>
Date: Thu Nov 30 18:34:30 2017

Do not skip overdraw optimization for non-display-list-2d canvas

Bug:  776826 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4c1d8898a5a983fc0368e792620696f5d90d788b
Reviewed-on: https://chromium-review.googlesource.com/800750
Commit-Queue: Olivia Lai <xlai@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520615}
[modify] https://crrev.com/74f45cf7fd9cdd165d04d6079cb54a56a1a47075/third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/74f45cf7fd9cdd165d04d6079cb54a56a1a47075/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/74f45cf7fd9cdd165d04d6079cb54a56a1a47075/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

Comment 3 by xlai@chromium.org, Nov 30 2017

Status: Started (was: Assigned)

Comment 4 by xlai@chromium.org, Dec 1 2017

Blocking: 776806
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571

commit 94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571
Author: xlai <xlai@chromium.org>
Date: Mon Dec 04 23:56:03 2017

Remove Canvas Display List 2D mode

As canvas is moving to use OOP rasterization, the display-list mode for its 2D
context is no longer relevant. We have disabled it several months ago and now
it is time to remove the code, so as to facilitate the canvas vizification
refactoring works.

TBR=xiyuan@chromium.org, pfeldman@chromium.org

Bug:  776826 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ida5a89ffdd24208afca4a098e8adad354ddf27e5
Reviewed-on: https://chromium-review.googlesource.com/801616
Reviewed-by: Olivia Lai <xlai@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521533}
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/chrome/browser/about_flags.cc
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/content/child/runtime_features.cc
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/content/public/common/content_switches.cc
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/README.txt
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-as-image-expected.png
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-as-image-incremental-repaint-expected.png
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-bg-zoom-expected.png
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-composite-repaint-by-all-imagesource-expected.txt
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-lost-gpu-context-expected.txt
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-pattern-video-expected.png
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-toDataURL-webp-expected.txt
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas-expected.txt
[delete] https://crrev.com/6a74476da0449200bd44f429042bc3bf385ed6ec/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/toDataURL-alpha-stability-expected.png
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/third_party/WebKit/public/platform/WebRuntimeFeatures.h
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/94b2f4f94c6d0e92fd078f7e776f7bff7fcc8571/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a955a22f1ccd057fbf9373031a19930f3291a23a

commit a955a22f1ccd057fbf9373031a19930f3291a23a
Author: xlai <xlai@chromium.org>
Date: Tue Dec 05 23:29:14 2017

Clean up Canvas heuristics after display list 2d mode is removed

Bug:  776826 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4c94e829690b37da7029fdf1105731fbf6c2b0b6
Reviewed-on: https://chromium-review.googlesource.com/809607
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521892}
[modify] https://crrev.com/a955a22f1ccd057fbf9373031a19930f3291a23a/third_party/WebKit/Source/platform/graphics/CanvasHeuristicParameters.h

Comment 7 by xlai@chromium.org, Dec 6 2017

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f16d12eef0d92ca5768f3aed42eb923c25c63b9

commit 2f16d12eef0d92ca5768f3aed42eb923c25c63b9
Author: xlai <xlai@chromium.org>
Date: Wed Jan 10 00:22:49 2018

Remove SnapshotReason

One last piece of removing display list 2d mode.

TBR=jbroman@chromium.org

Bug:  776826 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I46403f5bf65e17f0ca317d03e6d21e3b90b702eb
Reviewed-on: https://chromium-review.googlesource.com/857811
Commit-Queue: Olivia Lai <xlai@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528183}
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValue.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/html/canvas/ImageElementBase.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/html/canvas/ImageElementBase.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/html/media/HTMLVideoElement.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/html/media/HTMLVideoElement.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/canvas/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/canvas/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/platform/graphics/GraphicsTypes.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/platform/graphics/ImageBuffer.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h
[modify] https://crrev.com/2f16d12eef0d92ca5768f3aed42eb923c25c63b9/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContextTest.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6ba6a28a9d729d0e1b637f18585781dd5e216d4

commit d6ba6a28a9d729d0e1b637f18585781dd5e216d4
Author: xlai <xlai@chromium.org>
Date: Thu May 10 14:49:51 2018

Clean up display list 2d canvas flag in tests

TBR=junov@chromium.org,bajones@chromium.org

Bug:  776826 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Idacc96a19591ae2c5bfc0911243e6a38dcf8a402
Reviewed-on: https://chromium-review.googlesource.com/1052490
Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557516}
[modify] https://crrev.com/d6ba6a28a9d729d0e1b637f18585781dd5e216d4/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/d6ba6a28a9d729d0e1b637f18585781dd5e216d4/third_party/WebKit/LayoutTests/VirtualTestSuites

Sign in to add a comment