servo_v4: DUT always selects vSafe5v source cap due to unsupported voltage |
|||
Issue descriptionI didn't run into this issue due to having a 9V-limited servo_v4, but philipchen@ is probably running into this on scarlet -- We'll advertise the 'best' / highest-power PDO from the charge port to the DUT without regard to whether the DUT actually supports charging at that voltage. We can try parsing sink caps, but it's simpler to just advertise all PDOs to the DUT. Alternatively we can just advertise the 'best' 5V / 9V / 12V / 20V PDOs (we probably won't even need to touch common code for this).
,
Oct 24 2017
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/92c81a3e69bb09ad87fe40935eb81a561bca1318 commit 92c81a3e69bb09ad87fe40935eb81a561bca1318 Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Mon Oct 30 17:05:16 2017 servo_v4: Advertise multiple >5V PDOs to DUT Select optimal PDOs from the charger at various discrete voltage limits and advertise them all to the DUT, in case the DUT does not support the "best" > 5V PDO due to voltage limits. BUG= chromium:776809 BRANCH=servo TEST=On {samus, scarlet, kevin}, with zinger attached to DUT port, verify DUT + CHG negotiate to max supported voltage. On 'black' servo_v4 board, verify scarlet negotiates to 12V. Change-Id: Iea174e4f6bc303d561e28281b9ff20afb3073c25 Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/730877 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/740005 [modify] https://crrev.com/92c81a3e69bb09ad87fe40935eb81a561bca1318/board/servo_v4/usb_pd_policy.c |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 24 2017