New issue
Advanced search Search tips

Issue 776796 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 469639



Sign in to add a comment

AudioWorkletNode output channel is always mono

Project Member Reported by hongchan@chromium.org, Oct 20 2017

Issue description

See the attached file for repro case:

A simple worklet that just passes audio directly through from input to output.
It seems that the worklet always has mono input and output even if it's
processing the output of a stereo node.
 
worklet-implicit-mono.zip
381 KB Download
Fix: AudioWorkletNode must implement CheckNumberOfChannelsForInput().

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d016d124d2413159ea4ac0e4787238de5bf1d051

commit d016d124d2413159ea4ac0e4787238de5bf1d051
Author: Hongchan Choi <hongchan@chromium.org>
Date: Sat Oct 21 03:16:48 2017

Update AudioWorkletNode's channel count when input channel count changes

This CL implements CheckNumberOfChannelsForInput() method in
AudioWorkletNode, which changes output channel count when the node's
input channel count changes.

Bug:  776796 
Test: http/tests/webaudio/audio-worklet/dynamic-channel-count.html
Change-Id: I4c36d85ba55a864ffe5903825d0446d86652719e
Reviewed-on: https://chromium-review.googlesource.com/731503
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510649}
[add] https://crrev.com/d016d124d2413159ea4ac0e4787238de5bf1d051/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/dynamic-channel-count.html
[modify] https://crrev.com/d016d124d2413159ea4ac0e4787238de5bf1d051/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.cpp
[modify] https://crrev.com/d016d124d2413159ea4ac0e4787238de5bf1d051/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.h

Status: Verified (was: Started)

Sign in to add a comment