New issue
Advanced search Search tips

Issue 776737 link

Starred by 2 users
Status: Started
Owner:
jbudorick@chromium.org
Cc:
peconn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Link to post_test_screenshots is broken

Project Member Reported by dgn@chromium.org, Oct 20 2017 
the link from result details is

<a href="" target="_blank">post_test_screenshot</a>

With just opens a new tab with the current page instead of one showing the failure screenshot.

Sample build: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/15999

Comment 1 by jbudorick@chromium.org, Oct 20 2017 

We need to pass the test runner the GS bucket for non-text artifacts. It doesn't look like we've ever had post_test_screenshots enabled on these bots, but we weren't previously putting the link there.

Comment 2 by jbudorick@chromium.org, Oct 20 2017

Status: Started (was: Assigned)
Fix for chromium.android on review: https://chromium-review.googlesource.com/c/chromium/src/+/730418
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c707d39c04a9b28009a52e0f6a12f1571bb25235

commit c707d39c04a9b28009a52e0f6a12f1571bb25235
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Oct 20 22:34:32 2017

[android] Pass --gs-results-bucket to instrumentation tests on chromium.android.

Bug: 776737
Change-Id: I678b3865d98f13a3e25576cc540f265498d038ed
Reviewed-on: https://chromium-review.googlesource.com/730418
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510588}
[modify] https://crrev.com/c707d39c04a9b28009a52e0f6a12f1571bb25235/testing/buildbot/chromium.android.json
►

Sign in to add a comment