Issue 776727 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Oct 2017
Components:	Build
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Feature
Build-Tools-GN

GN: support --ninja-extra-args with MSVC

Project Member Reported by brianosman@chromium.org, Oct 20 2017

Issue description

--ninja-extra-args currently only works with --ide=xcode, but goma is useful on other OS/IDE combinations. Having that option present would be very helpful.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0738f52d11987091a239d61ab965e58f492516d7

commit 0738f52d11987091a239d61ab965e58f492516d7
Author: Brian Osman <brianosman@google.com>
Date: Mon Oct 30 20:15:45 2017

Support --ninja-extra-args with --ide=vs

Bug:  776727 
Change-Id: I401f31efa5a25033999e1cf5275275c7955fa41c
Reviewed-on: https://chromium-review.googlesource.com/731323
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#512592}
[modify] https://crrev.com/0738f52d11987091a239d61ab965e58f492516d7/tools/gn/command_gen.cc
[modify] https://crrev.com/0738f52d11987091a239d61ab965e58f492516d7/tools/gn/docs/reference.md
[modify] https://crrev.com/0738f52d11987091a239d61ab965e58f492516d7/tools/gn/visual_studio_writer.cc
[modify] https://crrev.com/0738f52d11987091a239d61ab965e58f492516d7/tools/gn/visual_studio_writer.h

Comment 2 by brianosman@chromium.org, Oct 30 2017

Status: Fixed (was: Untriaged)

►

Issue 776727 link

Issue metadata

GN: support --ninja-extra-args with MSVC

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 30 2017

Comment 1 Deleted

Comment 2 by brianosman@chromium.org, Oct 30 2017

Comment 2 Deleted

Sign in to add a comment