New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 776726 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move GlobalMemoryDumpRequestArgs to memory_instrumentation

Project Member Reported by hjd@chromium.org, Oct 20 2017 
Background context: go/memory-infra

After https://chromium-review.googlesource.com/c/chromium/src/+/723461
we have GlobalMemoryDumpRequestArgs in the wrong place because it still has a few base/ users, we should remove them and move GlobalMemoryDumpRequestArgs to memory_instrumentation::
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdade2017646743c2a9bf3b9948aed99430c1cec

commit fdade2017646743c2a9bf3b9948aed99430c1cec
Author: Lalit Maganti <lalitm@chromium.org>
Date: Mon Dec 11 14:53:41 2017

memory-infra: remove GlobalMemoryDumpArgs from base

This struct is essentially only an implementation detail of the
memory instrumentation coordinator and does not need to be exposed in
base.

Bug: 776726
Change-Id: I67336eb99d5677e9b18ae30213486927d12079d3
Reviewed-on: https://chromium-review.googlesource.com/813836
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Hector Dearman <hjd@chromium.org>
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523094}
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/base/trace_event/memory_dump_manager_test_utils.h
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/base/trace_event/memory_dump_request_args.h
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/services/resource_coordinator/memory_instrumentation/coordinator_impl.h
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.h
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.cc
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.typemap
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_struct_traits.cc
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_struct_traits.h
[modify] https://crrev.com/fdade2017646743c2a9bf3b9948aed99430c1cec/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
►

Sign in to add a comment