New issue
Advanced search Search tips

Issue 776709 link

Starred by 1 user
Status: Assigned
Owner:
perezju@chromium.org
Cc:
perezju@chromium.org
iannu...@google.com
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 777865


Sign in to add a comment

Catapult relies on specific "psutil" API versions

Project Member Reported by d...@chromium.org, Oct 20 2017 
For reference, see: https://bugs.chromium.org/p/chromium/issues/detail?id=762005

The "psutil" version on bots is very old, v1.2.1. This is largely because bots are running very old operating systems. This can't last forever, so we need to ensure that Catapult works with newer versions of these packages.

The specific version of "psutil" that a build runs against can be controlled using "vpython". On bots, the "vpython" package specification currently pulls in "psutil" v5.2.2: https://chromium.googlesource.com/chromium/src/+/master/.vpython

This bug is to increase Catapult and associated code's robustness with respect to "psutil" APIs for any supported revisions, as well as to document which "psutil" revisions Catapult intends to support.

P2 b/c things seem stable as-is, but this is obscure and should be fixed before it is forgotten.

Comment 1 by perezju@chromium.org, Oct 20 2017

Cc: jbudorick@chromium.org nednguyen@chromium.org
Components: Speed>Telemetry Test>Android
Owner: perezju@chromium.org
Status: Assigned (was: Untriaged)
+nednguyen and +jbudorick as this affects both telemetry and devil

Working on draft doc to assess the situation and discuss possible solutions:
https://docs.google.com/a/google.com/document/d/11z2Xy3uxZi-EritW0BGfOWmqA1toP2s0FloICOP5YDM/edit?usp=sharing

Comment 2 by perezju@chromium.org, Oct 24 2017 

As described on the design doc, the chosen outcome is to make psutil v2 or higher a requirement for both devil and Telemetry.

I'm planning first to land a CL adding a check for the psutil version.

Later, if nothing breaks, a follow up CL will clean up existing psutil clients that will no longer need to write hacks to support the deprecated version.

Comment 3 by perezju@chromium.org, Oct 24 2017

Cc: -nednguyen@chromium.org nedngu...@google.com

Comment 4 by perezju@chromium.org, Oct 25 2017

Blockedon: 777865
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/c5503564d23f528e580b7a6f867badfa06923c30

commit c5503564d23f528e580b7a6f867badfa06923c30
Author: Juan A. Navarro Perez <perezju@chromium.org>
Date: Mon Oct 30 14:45:28 2017

[devil] Make device_recovery compatible with both psutil v1 and v2

The older code worked on v1 (and older) only; and was a no-op on v2
(and higher).

The new code maintains compatibility across the psutil API change.

Also make the matching of "adb" processes stricter (match exact name).

Bug: chromium:776709
Change-Id: I190aca06c085783d225f0ed8c13c743dff3b9857
Reviewed-on: https://chromium-review.googlesource.com/743723
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/c5503564d23f528e580b7a6f867badfa06923c30/devil/devil/android/tools/device_recovery.py

Comment 6 by perezju@chromium.org, Nov 13 2017

Labels: -Pri-2 Pri-3
Lowering Pri on this at the moment, as the blocked on bug will probably take longer than initially expected.

Comment 7 by iannu...@google.com, Oct 18

Cc: -iannucci@chromium.org iannu...@google.com

Comment 8 by perezju@google.com, Dec 4 

The other day I was giving a look at this and it seems that, after many things have moved to vpython lately, this issue is now mostly fixable:
https://chromium-review.googlesource.com/c/catapult/+/1349356

The only remaining problem seems to be the non-luci Catapult Andriod Tryserver which runs device_recovery.py outside of vpython and picks up some old psutil version.

That script seems to be called from here:
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_android/api.py?rcl=59aca2e503c1f3ec7dd1f4638951f69b002578af&l=486

Unless I hear any objections (and whenever I find some more spare cycles), I'll try to flip that to vpython.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/81742fb78174976f6dbe71fb4990bccbc86cf632

commit 81742fb78174976f6dbe71fb4990bccbc86cf632
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Dec 07 08:31:21 2018

Run device_recovery with vpython

The script depends on psutil, and this will ensure it always uses the
correct version of the module.

At the moment this is made optional, with venv=False the default.
This will allow to switch repositories in stages, without complicated
non-trivial rolls.

Bug: 776709
Change-Id: I235e96feab253793141cfcdf3f8ce760d535e283
Reviewed-on: https://chromium-review.googlesource.com/c/1365335
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/asan_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_other_device_failure_during_recovery.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/upload_result_details_failures.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/asan_setup_failure.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_blacklisted_devices.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/gerrit_try_builder_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_with_step_warning.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/keep_data_install_tester_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_disable_location_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/downgrade_install_tester_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_failing_host_info.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_tests_infra_reference_failure.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_allow_high_battery_temp_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/webview_cts_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/no_cache_builder_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/gerrit_refs.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/telemetry_browser_tests_failures.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_no_devices_during_status.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_other_device_failure_during_status.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/basic_builder_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/result_details_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/coverage_builder_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_offline_devices.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_no_devices_during_recovery.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_tests_infra_failure.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/slow_tester_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_user_build_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_tests_failure.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/timestamp_as_point_id_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/upload_archives_to_bucket_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/remove_system_vrcore_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/stackwalker_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_tests_reference_failure.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/telemetry_browser_tests_tester_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/json_results_file_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/no_strict_mode_tester_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/resource_size_builder_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_adb_vendor_keys_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/device_flags_builder_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tombstones_m53.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/README.recipes.md
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/webview_tester_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_allow_low_battery_basic.json
[modify] https://crrev.com/81742fb78174976f6dbe71fb4990bccbc86cf632/scripts/slave/recipe_modules/chromium_android/examples/full.expected/use_devil_adb_basic.json
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/9acca89ae91fd7df92145bbaf1b8296459ffafe4

commit 9acca89ae91fd7df92145bbaf1b8296459ffafe4
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Dec 07 14:28:07 2018
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/894db8aa562b40291fef1f00baa348f9843f5d29

commit 894db8aa562b40291fef1f00baa348f9843f5d29
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Dec 10 14:02:17 2018

[tools/perf] Remove unused psutil module

The "optionally" imported module is not being used at all.

Bug: 776709
Change-Id: I08cf3cb7a109e737730bd13395021c34793b67eb
Reviewed-on: https://chromium-review.googlesource.com/c/1366289
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615110}
[modify] https://crrev.com/894db8aa562b40291fef1f00baa348f9843f5d29/tools/perf/core/results_dashboard.py
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/6fef91de94c6a192704f797588deefabc8f78e31

commit 6fef91de94c6a192704f797588deefabc8f78e31
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Dec 10 15:29:18 2018
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ff913ed3b55d20bb3f944d31fd8da79348a2cec2

commit ff913ed3b55d20bb3f944d31fd8da79348a2cec2
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Dec 10 17:50:02 2018

Switch cronet recipes to do device_recovery with vpython

Also exposes a temporary venv option on run_tests for build_internal
clients to be able to make the switch too.

Bug: 776709
Change-Id: Ib5cf7c834539698def5927af435d887a40bfbc03
Reviewed-on: https://chromium-review.googlesource.com/c/1370047
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipes/cronet.expected/cronet_try.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipe_modules/cronet/examples/full.expected/gn_test.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipes/cronet.expected/android_cronet_tester.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_builder.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipe_modules/cronet/examples/full.expected/local_test.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipes/cronet.expected/local_test.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/README.recipes.md
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipes/cronet.py
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipe_modules/cronet/examples/full.expected/mb_test.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipe_modules/cronet/tests/run_tests.py
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipe_modules/cronet/examples/full.py
[modify] https://crrev.com/ff913ed3b55d20bb3f944d31fd8da79348a2cec2/scripts/slave/recipe_modules/cronet/api.py
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/eae18d7a380a54fc2a4d55b5e8dbd924d4416628

commit eae18d7a380a54fc2a4d55b5e8dbd924d4416628
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Dec 13 09:12:10 2018
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/80ec5f342f0d1c8c23638d2574205a97a9afeb8e

commit 80ec5f342f0d1c8c23638d2574205a97a9afeb8e
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Dec 13 12:07:09 2018

Switch remaining device_recovery clients to vpython

The venv option still remains (since it's used in other repositories)
but now must be set to True everywhere.

After removing the option from callers on a follow up CL, this can be
removed too.

Bug: 776709
Change-Id: I48c3065d0b5c212fd18f001d8a08e12f7c55082d
Reviewed-on: https://chromium-review.googlesource.com/c/1367791
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/stackwalker_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_fyi_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/asan_setup_failure.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/gerrit_try_builder_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/keep_data_install_tester_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/webview_tester_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_custom_name.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/webview_cts_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/telemetry_browser_tests_failures.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_fyi_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_tests_infra_failure.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/slow_tester_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_failed_device.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_nexus5_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_disconnected_device.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/upload_archives_to_bucket_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_rel.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/json_results_file_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_offline_devices.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_tester_arm32_debug__nexus_5x_.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/device_flags_builder_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/resource_size_builder_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_no_device.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_blacklisted_devices.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_disable_location_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tombstones_m53.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_allow_high_battery_temp_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/no_cache_builder_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/gerrit_refs.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/coverage_builder_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_no_device.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_tests/tests/api/wrap_chromium_tests.expected/instrumentation_test.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_fyi_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_fyi_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/no_strict_mode_tester_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_adb_vendor_keys_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/README.recipes.md
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_basic_device.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_basic_device.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/asan_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_with_step_warning.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_failing_host_info.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_nexus6_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/basic_builder_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/result_details_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/remove_system_vrcore_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__n_pixel_.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_arm64.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_user_build_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_nexus7_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_tests_failure.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_disconnected_device.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/timestamp_as_point_id_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_tests_reference_failure.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/telemetry_browser_tests_tester_basic.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/80ec5f342f0d1c8c23638d2574205a97a9afeb8e/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Test
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0ceaeff900d4fff7e78cbd1cb87c9d90c73f9f3d

commit 0ceaeff900d4fff7e78cbd1cb87c9d90c73f9f3d
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Dec 17 10:45:40 2018

Switch cronet.run_tests venv default to True

TBR=jbudorick@chromium.org
Bug: 776709
Change-Id: Id9ded99ae39fe8f38d0caeb899e576c461244f14
Reviewed-on: https://chromium-review.googlesource.com/c/1378757
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/0ceaeff900d4fff7e78cbd1cb87c9d90c73f9f3d/scripts/slave/README.recipes.md
[modify] https://crrev.com/0ceaeff900d4fff7e78cbd1cb87c9d90c73f9f3d/scripts/slave/recipe_modules/cronet/api.py
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/39488be0674ff45a4d7c588916d42c7a81f549d6

commit 39488be0674ff45a4d7c588916d42c7a81f549d6
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Tue Dec 18 16:57:35 2018
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e4b19a218dc398c28ef618a35aa8715768d554c4

commit e4b19a218dc398c28ef618a35aa8715768d554c4
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Jan 14 16:37:44 2019

[py_utils] Add modules_util.RequireVersion

The core of Telemetry's external_modules.ImportRequiredModule is
extracted to a py_utils module to allow reuse by other catapult
projects.

This is in preparation for the eventual deprecation of
external_modules itself, which is due to be replaced by the use
of vpython dependencies instead.

This CL also uses the new module in devil's device_recovery.py
which already runs using vpython everywhere.

Bug: chromium:776709
Bug: chromium:777865
Change-Id: I68ecae5c67c821b8aa809507eac826f0457af5c5
Reviewed-on: https://chromium-review.googlesource.com/c/1394564
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/e4b19a218dc398c28ef618a35aa8715768d554c4/telemetry/telemetry/internal/util/external_modules.py
[modify] https://crrev.com/e4b19a218dc398c28ef618a35aa8715768d554c4/devil/devil/android/tools/device_recovery.py
[modify] https://crrev.com/e4b19a218dc398c28ef618a35aa8715768d554c4/telemetry/telemetry/internal/platform/android_platform_backend_unittest.py
[add] https://crrev.com/e4b19a218dc398c28ef618a35aa8715768d554c4/common/py_utils/py_utils/modules_util_unittest.py
[add] https://crrev.com/e4b19a218dc398c28ef618a35aa8715768d554c4/common/py_utils/py_utils/modules_util.py

Comment 20 by nedngu...@google.com, Jan 14

Cc: -nedngu...@google.com
Project Member

Comment 21 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a3d272ff14a633caf6477e68dfd4c334701562fd

commit a3d272ff14a633caf6477e68dfd4c334701562fd
Author: Juan Antonio Navarro Pérez <perezju@chromium.org>
Date: Tue Jan 15 13:25:22 2019

Revert "[py_utils] Add modules_util.RequireVersion"

This reverts commit e4b19a218dc398c28ef618a35aa8715768d554c4.

Reason for revert: Blocking catapult autoroll

Original change's description:
> [py_utils] Add modules_util.RequireVersion
> 
> The core of Telemetry's external_modules.ImportRequiredModule is
> extracted to a py_utils module to allow reuse by other catapult
> projects.
> 
> This is in preparation for the eventual deprecation of
> external_modules itself, which is due to be replaced by the use
> of vpython dependencies instead.
> 
> This CL also uses the new module in devil's device_recovery.py
> which already runs using vpython everywhere.
> 
> Bug: chromium:776709
> Bug: chromium:777865
> Change-Id: I68ecae5c67c821b8aa809507eac826f0457af5c5
> Reviewed-on: https://chromium-review.googlesource.com/c/1394564
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Annie Sullivan <sullivan@chromium.org>
> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

TBR=sullivan@chromium.org,perezju@chromium.org,crouleau@chromium.org,jbudorick@chromium.org

Change-Id: I157894b7f2d059c25656e33b6650b98d11c65962
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:776709, chromium:777865
Reviewed-on: https://chromium-review.googlesource.com/c/1411604
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/a3d272ff14a633caf6477e68dfd4c334701562fd/telemetry/telemetry/internal/util/external_modules.py
[modify] https://crrev.com/a3d272ff14a633caf6477e68dfd4c334701562fd/devil/devil/android/tools/device_recovery.py
[modify] https://crrev.com/a3d272ff14a633caf6477e68dfd4c334701562fd/telemetry/telemetry/internal/platform/android_platform_backend_unittest.py
[delete] https://crrev.com/46491773618e58e3f1a928759ff35164c5c4db11/common/py_utils/py_utils/modules_util_unittest.py
[delete] https://crrev.com/46491773618e58e3f1a928759ff35164c5c4db11/common/py_utils/py_utils/modules_util.py

Comment 22 by perezju@chromium.org, Jan 15 

That CL didn't stick. It was failing during catapult autoroll with the error:

  File "/b/swarming/w/ir/build/android/test_runner.py", line 44, in <module>
    from pylib.base import test_run_factory
  File "/b/swarming/w/ir/build/android/pylib/base/test_run_factory.py", line 11, in <module>
    from pylib.local.device import local_device_gtest_run
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_gtest_run.py", line 25, in <module>
    from pylib.local.device import local_device_test_run
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_test_run.py", line 16, in <module>
    from devil.android.tools import device_recovery
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/tools/device_recovery.py", line 31, in <module>
    from py_utils import modules_util
ImportError: cannot import name modules_util
https://chromium-swarm.appspot.com/task?id=426a04bab2a46f10&refresh=10&show_raw=1

Comment 23 by perezju@chromium.org, Jan 15 

Sounds like I need to add modules_util.py to the file here:
https://cs.chromium.org/chromium/src/build/android/test_runner.pydeps?rcl=8c43e923981181fa506020964f25e673a504062b&l=15

Does it work if I add the file there before relanding #19?

Or do I need to (1) add modules_util.py first, (2) update test_runner.pydeps, (3) reland #19?

Comment 24 by perezju@chromium.org, Jan 15 

I've just answered my question in #23. A three sided patch is needed. Working on that ...
Project Member

Comment 25 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d39cb7402e371e19d1485f07270953c266d4cd

commit c9d39cb7402e371e19d1485f07270953c266d4cd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 16 02:43:37 2019

Roll src/third_party/catapult 96320b515106..78448d90081e (17 commits)

https://chromium.googlesource.com/catapult.git/+log/96320b515106..78448d90081e


git log 96320b515106..78448d90081e --date=short --no-merges --format='%ad %ae %s'
2019-01-15 vollick@chromium.org Plumb the trace buffer size for atrace
2019-01-15 perezju@chromium.org Revert "[py_utils] Add modules_util.RequireVersion"
2019-01-15 taylori@google.com Fix handling of perfetto protobuf on mac
2019-01-15 perezju@chromium.org [dashboard] Remove dead code in start_try_job.py
2019-01-15 perezju@chromium.org Revert "Remove TagMap."
2019-01-15 perezju@chromium.org [Telemetry] Add list_of_scalar_values.mean
2019-01-15 dtu@chromium.org [pinpoint] Add Tags field to try job dialog.
2019-01-15 dtu@chromium.org [pinpoint] Ignore cached isolate hashes over 8 weeks old.
2019-01-14 eroman@chromium.org Fix import of new NetExport generated logs.
2019-01-14 bsheedy@chromium.org Fix gtest conversion multiplier
2019-01-14 eyaich@google.com Adding timeToFirstViewportReady metric
2019-01-14 perezju@chromium.org [py_utils] Add modules_util.RequireVersion
2019-01-14 perezju@chromium.org Remove GetNetworkData methods
2019-01-14 perezju@chromium.org [cli services] Add buildbucket_service
2019-01-14 perezju@chromium.org [Telemetry] Remove TBMv1 metrics.SmoothnessMetric
2019-01-11 benjhayden@chromium.org Remove TagMap.
2019-01-11 benjhayden@chromium.org Truncate serialized floats in HistogramSet JSON.


Created with:
  gclient setdep -r src/third_party/catapult@78448d90081e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:776709,chromium:777865,chromium:918218,chromium:921616,chromium:874940,chromium:916877, chromium:917273 ,chromium:921342,chromium:904879,chromium:776709,chromium:777865,chromium:480512, chromium:919093 , chromium:691581 ,chromium:921000,chromium:918218,chromium:918208
TBR=sullivan@chromium.org

Change-Id: I75c07d8719f5668f9b4a95a9757cf6c25412b547
Reviewed-on: https://chromium-review.googlesource.com/c/1413252
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623062}
[modify] https://crrev.com/c9d39cb7402e371e19d1485f07270953c266d4cd/DEPS

Comment 26 by benhenry@google.com, Jan 16

Components: Test>Telemetry

Comment 27 by benhenry@google.com, Jan 16

Components: -Speed>Telemetry
Project Member

Comment 28 by bugdroid1@chromium.org, Jan 17 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a0e5e3328cd7578d4e2aeeb8d7675a60fd00a74f

commit a0e5e3328cd7578d4e2aeeb8d7675a60fd00a74f
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Jan 17 12:20:15 2019

Reland "[py_utils] Add modules_util.RequireVersion"

The core of Telemetry's external_modules.ImportRequiredModule is
extracted to a py_utils module to allow reuse by other catapult
projects.

This is in preparation for the eventual deprecation of
external_modules itself, which is due to be replaced by the use
of vpython dependencies instead.

This is a reland of:
https://chromium-review.googlesource.com/c/catapult/+/1394564
without the changes in devil.

Bug: chromium:776709
Change-Id: Iad836eb24c9d0b0fb0f1c2d6b735ee20aee730c8
TBR=crouleau@chromium.org,sullivan@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1411605
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/a0e5e3328cd7578d4e2aeeb8d7675a60fd00a74f/telemetry/telemetry/internal/util/external_modules.py
[modify] https://crrev.com/a0e5e3328cd7578d4e2aeeb8d7675a60fd00a74f/telemetry/telemetry/internal/platform/android_platform_backend_unittest.py
[add] https://crrev.com/a0e5e3328cd7578d4e2aeeb8d7675a60fd00a74f/common/py_utils/py_utils/modules_util_unittest.py
[add] https://crrev.com/a0e5e3328cd7578d4e2aeeb8d7675a60fd00a74f/common/py_utils/py_utils/modules_util.py
Project Member

Comment 29 by bugdroid1@chromium.org, Jan 17 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f2870c586fdfccb9c449e80635fe774ea586f1

commit d9f2870c586fdfccb9c449e80635fe774ea586f1
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Jan 17 14:50:29 2019

Roll src/third_party/catapult ff5a19a8ec57..a0e5e3328cd7 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/ff5a19a8ec57..a0e5e3328cd7


git log ff5a19a8ec57..a0e5e3328cd7 --date=short --no-merges --format='%ad %ae %s'
2019-01-17 perezju@chromium.org Reland "[py_utils] Add modules_util.RequireVersion"


Created with:
  gclient setdep -r src/third_party/catapult@a0e5e3328cd7

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:776709
TBR=sullivan@chromium.org

Change-Id: I1f564ad51f682e8496970592e6c2a2a27bf6a9dd
Reviewed-on: https://chromium-review.googlesource.com/c/1417285
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623682}
[modify] https://crrev.com/d9f2870c586fdfccb9c449e80635fe774ea586f1/DEPS
Project Member

Comment 30 by bugdroid1@chromium.org, Jan 17 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5be60d4974e6720cfc1b215173ecf7c6c858e996

commit 5be60d4974e6720cfc1b215173ecf7c6c858e996
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Jan 17 16:48:47 2019

[build/android] Add py_utils.modules_util to test_runner.pydeps

A new module needed by device_recovery.py is getting added.

Bug: 776709
Change-Id: I5a9a62ff6b545d97ede87b6e98656ed32a2fffb2
Reviewed-on: https://chromium-review.googlesource.com/c/1411639
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623718}
[modify] https://crrev.com/5be60d4974e6720cfc1b215173ecf7c6c858e996/build/android/test_runner.pydeps
Project Member

Comment 31 by bugdroid1@chromium.org, Jan 18 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/4ac0b64bb236fc6a4b7c715113f31c450033977f

commit 4ac0b64bb236fc6a4b7c715113f31c450033977f
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Jan 18 15:46:57 2019

[devil] Ensure device_recovery uses correct psutil version

This should be already the case, but lets add a strict check to get
alerted in case of errors or misconfigurations.

Bug: chromium:776709
Change-Id: I5bed1070a4b7e9f726b340bcd368182b7aabf5aa
Reviewed-on: https://chromium-review.googlesource.com/c/1421399
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/4ac0b64bb236fc6a4b7c715113f31c450033977f/devil/devil/android/tools/device_recovery.py
Project Member

Comment 32 by bugdroid1@chromium.org, Jan 18 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb35e4508825f3052b5c70a32f8156792d7184b8

commit cb35e4508825f3052b5c70a32f8156792d7184b8
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 18 17:19:07 2019

Roll src/third_party/catapult 1f939034d069..4ac0b64bb236 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/1f939034d069..4ac0b64bb236


git log 1f939034d069..4ac0b64bb236 --date=short --no-merges --format='%ad %ae %s'
2019-01-18 perezju@chromium.org [devil] Ensure device_recovery uses correct psutil version


Created with:
  gclient setdep -r src/third_party/catapult@4ac0b64bb236

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:776709
TBR=sullivan@chromium.org

Change-Id: I1bd2b95a64b5f4fc35422577cf01437aa74dc60b
Reviewed-on: https://chromium-review.googlesource.com/c/1422098
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#624174}
[modify] https://crrev.com/cb35e4508825f3052b5c70a32f8156792d7184b8/DEPS
►

Sign in to add a comment