New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 776687 link

Starred by 2 users
Status: Fixed
Owner:
█ sfiera@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
treib@chromium.org
█ tabanao@google.com
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Local NTP: Gray doodle background

Project Member Reported by treib@chromium.org, Oct 20 2017 
The CTA image for today's Doodle has a gray background on the local NTP.
Also, the size of the CTA image is different from the size of the animated image.
(Both things work correctly on the remote NTP.)

After clicking the CTA, the animated image gets a keyboard focus ring. That *might* be intended for a11y reasons I guess, but it does look weird.

And finally, the gif has a small gray line at the bottom. That's caused by #logo-doodle-button being 3 pixels taller than the actual image.
ntp_doodle_cta.png
146 KB View Download
ntp_doodle_anim.png
108 KB View Download
ntp_doodle_anim_focus.png
104 KB View Download

Comment 1 by treib@chromium.org, Oct 20 2017 

As far as I can tell, the CTA image is actually exactly the same between local and remote NTP, but the remote NTP rescales it from 550px to 500px width. I don't know why yet.

The image has a transparent border, which causes the gray background on the NTP. (I guess gray is the default background color for a <button>?) This can be fixed by setting "background: transparent" on #logo-doodle-button.

Comment 2 by fi...@chromium.org, Oct 23 2017

Labels: zine-triaged

Comment 3 by sfiera@chromium.org, Oct 25 2017

Labels: zine-local-ntp-doodles
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b025f38e480ca0964457142ac7f805c70c0a084d

commit b025f38e480ca0964457142ac7f805c70c0a084d
Author: Chris Pickel <sfiera@chromium.org>
Date: Wed Oct 25 13:05:08 2017

Local NTP: reset <button> CSS

It's used for doodles, and may be used for more things in the future,
so remove all border/margin/padding/background.

Bug:  776687 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If6c79660384d3d870989eaad9f3ffd1d1f2a8956
Reviewed-on: https://chromium-review.googlesource.com/733821
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511430}
[modify] https://crrev.com/b025f38e480ca0964457142ac7f805c70c0a084d/chrome/browser/resources/local_ntp/local_ntp.css

Comment 5 by sfiera@chromium.org, Oct 25 2017

Status: Fixed (was: Assigned)
The gray background is fixed.

I don't know if you want separate bugs for the other things you noticed, but it's not clear that there's anything for us to fix for them.

Comment 6 by treib@chromium.org, Oct 25 2017 

I think we settled on not doing anything about the image size mismatch.
That leaves the keyboard focus. I'll file a separate bug for that.
►

Sign in to add a comment