Issue metadata
Sign in to add a comment
|
Label layout issue in Urkainian localisation (Chrome Welcome Dialog)
Reported by
paste...@gmail.com,
Oct 20 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36 Steps to reproduce the problem: 1. make a clean install of Chrome 2. the dialog asking to make Chrome a default browser and to send diagnostic data to Chrome developers appears What is the expected behavior? The label asking to allow sending diagnostic data shouldn't be crossed by an NSBox What went wrong? Label is laid out so that it is crossed by a decoration line. See screenshot Did this work before? N/A Chrome version: 62.0.3202.62 Channel: stable OS Version: OS X 10.13.0 Flash Version:
,
Oct 20 2017
,
Oct 20 2017
[macbugtriage] -> ellyjones@
,
Oct 23 2017
Won't get to this this week - will look next monday.
,
Oct 25 2017
Somehow I am not getting the dialog installing the 62.0.3202.62 on Mac OS 10.12.6 as per the below steps: 1. Downloaded the installation file. 2. Opened the file called 'googlechrome.dmg'. 3. In the window that opens, found Chrome . 4. Dragged Chrome to the Applications folder. Entered admin password 5. Launched chrome 6. No Dialogue box is seen. I had removed the earlier chrome version by removing Google folder from the Library and chrome from application
,
Oct 30 2017
The NextAction date has arrived: 2017-10-30
,
Oct 31 2017
@ellyjones-- Could you please check and help us in triaging the issue , as TE is unable to reproduce the issue. Thanks!
,
Oct 31 2017
#5: you need to be running Chrome for the first time with your user-data-dir, so instead of your step 5, open a terminal and run: $ /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --user-data-dir=/tmp/test This will run chrome with a fresh user-data-dir in /tmp/test, which will cause the first run flow to happen. That said, I have reproduced this bug locally: 1) Set system primary language to Russian or Ukranian 2) Run chrome with a fresh user-data-dir 3) Broken layout results
,
Oct 31 2017
Russian screenshot attached.
,
Nov 1 2017
Screenshot attached for https://chromium-review.googlesource.com/c/chromium/src/+/749582
,
Nov 1 2017
Test screenshot as of https://chromium-review.googlesource.com/c/chromium/src/+/749315
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f65944765c1e3072bf9ae72fa9f4fafbd31453bb commit f65944765c1e3072bf9ae72fa9f4fafbd31453bb Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Nov 01 19:32:10 2017 cocoa: fix layout of first run dialog with long localized strings In locales with significantly longer strings, the checkbox labels can require wrapping, which may require moving all the controls below them downward and growing the window vertically. This change: 1) Adds support for the resizing and reflowing mentioned above; 2) Adds a new command-line flag "--force-unofficial-first-run", which causes the First Run flow to happen even on non-branded builds. Bug: 776683 Change-Id: I51952a79340248ccf3ea223538a679edaa4678e6 Reviewed-on: https://chromium-review.googlesource.com/749315 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#513215} [modify] https://crrev.com/f65944765c1e3072bf9ae72fa9f4fafbd31453bb/chrome/browser/ui/cocoa/first_run_dialog.mm [modify] https://crrev.com/f65944765c1e3072bf9ae72fa9f4fafbd31453bb/chrome/browser/ui/cocoa/first_run_dialog_controller.mm [modify] https://crrev.com/f65944765c1e3072bf9ae72fa9f4fafbd31453bb/chrome/common/chrome_switches.cc [modify] https://crrev.com/f65944765c1e3072bf9ae72fa9f4fafbd31453bb/chrome/common/chrome_switches.h
,
Nov 2 2017
This is fixed now. Do we care to merge this to M62?
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10ddbba67060778811b88195d74200a5b81a2294 commit 10ddbba67060778811b88195d74200a5b81a2294 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Nov 02 13:21:39 2017 ui: add support for mangling localized strings Often, the lengths of strings change significantly depending on the current locale. This can make testing a UI's layout sufficiently challenging, because there may be another locale in which the UI's strings are too long and the layout breaks. This change adds the ability to have all localized strings mangled to be both longer and very visually distinctive, which helps flush out: 1) Layouts that don't work in locales with longer strings 2) Places where localized strings are being silently truncated 3) Places where double localization (or no localization) happens Bug: 776683 Change-Id: I88b4df70c7a5360227cbdc0628edccf517653ec2 Reviewed-on: https://chromium-review.googlesource.com/749582 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#513474} [modify] https://crrev.com/10ddbba67060778811b88195d74200a5b81a2294/ui/base/resource/resource_bundle.cc [modify] https://crrev.com/10ddbba67060778811b88195d74200a5b81a2294/ui/base/resource/resource_bundle.h [modify] https://crrev.com/10ddbba67060778811b88195d74200a5b81a2294/ui/base/ui_base_switches.cc [modify] https://crrev.com/10ddbba67060778811b88195d74200a5b81a2294/ui/base/ui_base_switches.h
,
Nov 2 2017
+shrike +govind(for M63) We're already rolling out M62 to Stable. My recommendation is to target this for M-63 (if needed). I don't think this appears to be critical enough to merge to M62 now. Rejecting merge, but if you disagree and think it's critical, please re-request.
,
Nov 2 2017
> I don't think this appears to be critical enough to merge to M62 now. Agreed. I'd also like a post mortem-y doc or write-up so we understand how this bug slipped in and list ways to prevent similar regressions in the future.
,
Nov 2 2017
M63 is also in Beta and we're only taking critical merges in. As this is not M63 regression, can this wait until M64?
,
Nov 2 2017
Sure.
,
Nov 20 2017
,
Nov 20 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rsesek@chromium.org
, Oct 20 2017Components: -UI UI>Browser>FirstRun UI>Internationalization