Add UMA for password imports from Firefox |
|||
Issue descriptionOnce generic password import export is launched (tracked in bug 341477), it may not pay off to maintain the specific Firefox importer (chrome/utility/importer/firefox_importer.*, accessible from chrome://settings/importData) any longer. This ticket should track adding UMA on the usage of the importer. Initial suggestion for metrics: (1) How often the user chooses passwords in the chrome://settings/importData dialogue? (2) How much passwords end up imported in a single call to FirefoxImporter::ImportPasswords? Details: (1) could be a boolean histogram PasswordImporter.SelectedByUser in FirefoxImporter::StartImport, which records whether |items| contain the bit |importer::PASSWORDS|. (2) could be a bucketed histogram PasswordImporter.NumberOfImportedPasswords in FirefoxImporter::ImportPasswords, measuring |forms.size()|.
,
Oct 23 2017
,
Oct 24 2017
I'm interested in making a patch for this. Can I? BTW, how about changing the name of keys to be more specific, like Firefox.PasswordImporter.SelectedByUser and Firefox.PasswordImporter.NumberOfImportedPasswords. Just my opinion.
,
Oct 25 2017
Thanks for volunteering! Yes please, feel free to go ahead and add the histograms. The names you suggest look better to me than what I originally suggested (I like how your proposal is specific about those being Firefox imports).
,
Oct 27 2017
,
Oct 30 2017
I've uploaded a patch. Could you review that? Thanks! https://chromium-review.googlesource.com/c/chromium/src/+/744061
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e9770ac2a7c830bccd319a1af721a3c9f887eb9 commit 5e9770ac2a7c830bccd319a1af721a3c9f887eb9 Author: Jinyoung Hur <hurims@gmail.com> Date: Fri Nov 10 01:41:59 2017 Add UMA for Firefox passwords import This CL add the following UMA: 1. If password is selected by user when importing Firefox profiles. 2. How many passwords are imported from Firefox. R=isherman@chromium.org, vabr@chromium.org Bug: 776664 Change-Id: Ife7b1079502d4c4f0ebd2fb473bceb5feec7ddbc Reviewed-on: https://chromium-review.googlesource.com/744061 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515407} [modify] https://crrev.com/5e9770ac2a7c830bccd319a1af721a3c9f887eb9/AUTHORS [modify] https://crrev.com/5e9770ac2a7c830bccd319a1af721a3c9f887eb9/chrome/utility/importer/firefox_importer.cc [modify] https://crrev.com/5e9770ac2a7c830bccd319a1af721a3c9f887eb9/tools/metrics/histograms/histograms.xml
,
Nov 10 2017
,
Feb 7 2018
Just for record, today's state of the metrics (Chrome stable without any generic import feature) is: * about 700 times per day a non-zero number of passwords is imported * about 1400 imports per day have "import passwords" included Will be interesting to check if these metrics approach zero once the importing is introduced. |
|||
►
Sign in to add a comment |
|||
Comment 1 by vabr@chromium.org
, Oct 23 2017