New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 776655 link

Starred by 2 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Oct 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Gmail', 'Images' and 'Google apps' link are not seen on Google NTP.

Reported by db...@etouch.net, Oct 20 2017 
Chrome Version:  64.0.3245.0 Revision 140f8ce04cc4ee5d4b3ca2eb83888d2452a1f43b-refs/heads/master@{#510270}(32/64 bit)
OS: Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6)

What steps will reproduce the problem?
(1) Launch chrome, open NTP and observe on 'Gmail', 'Images'and 'Google apps' link.

Actual: 'Gmail', 'Images' and 'Google apps' link are not seen on Google NTP.

Expected: 'Gmail', 'Images' and 'Google apps' link should seen on Google NTP.

This is a regression issue, broken in 'M-64', will soon update the other info:

Good build:64.0.3244.0
Bad Build: 64.0.3245.0
Actual_NTP.mov
2.4 MB Download
Expected_NTP.mov
874 KB Download

Comment 1 by db...@etouch.net, Oct 20 2017

Labels: hasbisect-per-rivision
Owner: treib@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 510038 (known good), but no later than 510039 (first known bad).
CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/d54d7720c320abe789fa929ed9846474c699094e..06d66032b7347e23e4ff2f49a8692efc5ad07d1c

Suspect: https://chromium.googlesource.com/chromium/src/+/06d66032b7347e23e4ff2f49a8692efc5ad07d1c

Comment 2 by treib@chromium.org, Oct 20 2017

Labels: OS-Chrome
Status: Started (was: Assigned)
This has the same root cause as  issue 776660 ; I'll update there.

Comment 3 by ranjitkan@chromium.org, Oct 20 2017

Labels: ReleaseBlock-Beta
Tagging with blocker label, please undo if not the case.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/453cdca9a87018ae26b911899beb6394eaa17ecd

commit 453cdca9a87018ae26b911899beb6394eaa17ecd
Author: Marc Treib <treib@chromium.org>
Date: Fri Oct 20 11:29:19 2017

embeddedSearch API: Expose static functions

This makes sure they can be called after being assigned to a var, like
var f = chrome.embeddedSearch.searchBox.startCapturingKeyStrokes;
f();

This was the case when the API was implemented as a v8::Extension, but
got broken when it was converted to Gin in crrev.com/c/700443.

Bug:  776660 ,  776655 
Change-Id: Idab6a6e960ff614c80f74b3acdadede7bf9af9d0
Reviewed-on: https://chromium-review.googlesource.com/730186
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510401}
[modify] https://crrev.com/453cdca9a87018ae26b911899beb6394eaa17ecd/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/453cdca9a87018ae26b911899beb6394eaa17ecd/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/453cdca9a87018ae26b911899beb6394eaa17ecd/chrome/renderer/searchbox/searchbox_extension.cc
[modify] https://crrev.com/453cdca9a87018ae26b911899beb6394eaa17ecd/chrome/renderer/searchbox/searchbox_extension.h

Comment 5 by treib@chromium.org, Oct 20 2017

Status: Fixed (was: Started)
►

Sign in to add a comment