[Password Manager] Replace "via [hostname]" with "Sign in via [hostname]" in a prompt for federated credentials |
|||||
Issue descriptionReplace "via [hostname]" with "Sign in via [hostname]" in a prompt for federated credentials
,
Nov 9 2017
Max: FYI see screenshot in #1.
,
Nov 9 2017
Account chooser
,
Nov 9 2017
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/571c259e38333998d36e4373702386996ab012b7 commit 571c259e38333998d36e4373702386996ab012b7 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Thu Nov 09 13:56:06 2017 [Password Manager] Change the text for federated credential's value Bug: 776653 Change-Id: I8474509483fe8e582dd85f880aa3c318988f362a Reviewed-on: https://chromium-review.googlesource.com/758677 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#515161} [modify] https://crrev.com/571c259e38333998d36e4373702386996ab012b7/chrome/app/generated_resources.grd [modify] https://crrev.com/571c259e38333998d36e4373702386996ab012b7/chrome/browser/ui/views/passwords/manage_password_items_view.cc
,
Nov 9 2017
,
Nov 10 2017
Oh, there is a typo in the screenshots. :) It should be "Sign in" (instead of "Sing in"). Long term I still think we should consider a solution like in the attachment for the save dialog.
,
Nov 10 2017
Yes, I fixed it :) See what we landed in the screenshot. It is "Sign in".
,
Nov 10 2017
Tested the issue on Windows 10, Mac 10.12.6 and Ubuntu 14.04 using Chrome version M64 - 64.0.3264.0 as per the issue mentioned in original comment. Observed that issue is working as intended (Clicking on "Save your password" button in omnibox, the text "Sign in with" is noticed before hostname in the bubble displayed). Hence adding TE-Verified label. Attached the screenshot for reference. Thank you!
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e94312307129b5d1cdeeb0c45374ca651e98b80 commit 0e94312307129b5d1cdeeb0c45374ca651e98b80 Author: Peter Boström <pbos@chromium.org> Date: Mon Jan 08 20:36:41 2018 Fix federation label in ManagePasswordItemsView. Inadvertedly got changed to "Sign in with <URL>" with other dialogs. Bug: chromium:654115 , chromium:776653 Change-Id: Ia661f5b491ef0439ca5fc63c2c657f188407ce8c Reviewed-on: https://chromium-review.googlesource.com/764432 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#527742} [modify] https://crrev.com/0e94312307129b5d1cdeeb0c45374ca651e98b80/chrome/browser/ui/views/passwords/manage_password_items_view.cc [modify] https://crrev.com/0e94312307129b5d1cdeeb0c45374ca651e98b80/chrome/browser/ui/views/passwords/manage_password_items_view.h [modify] https://crrev.com/0e94312307129b5d1cdeeb0c45374ca651e98b80/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Jan 9 2018
Tested the issue on Windows 10, Mac 10.12.6 and Ubuntu 14.04 using Chrome version M65 - 65.0.3316.0 as per the issue mentioned in original comment. Observed that issue is working as intended (Clicking on "Save your password" button in omnibox, the text "Sign in with" is noticed before hostname in the bubble displayed). Hence adding TE-Verified label. Attached the screenshot for reference. Reference test URL: https://w3c.github.io/webappsec/demos/credential-management/ Thank you!
,
Jan 9 2018
Screenshot attached. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kolos@chromium.org
, Nov 9 201716.0 KB
16.0 KB View Download