Mac

Deleted: Screen Shot 2017-10-20 at 15.39.23.png 18.2 KB

	Screen Shot 2017-10-20 at 15.39.23.png 18.2 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a97a1a31400d129b46072c2088b6657909bf842b

commit a97a1a31400d129b46072c2088b6657909bf842b
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Oct 20 14:19:43 2017

[Password Manager] Remove "Password" label in a save prompt for federated credentials

Bug:  776652 
Change-Id: Iad3f7745595668279221a27548abe698787bf826
Reviewed-on: https://chromium-review.googlesource.com/729860
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510426}
[modify] https://crrev.com/a97a1a31400d129b46072c2088b6657909bf842b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b370649e387d31294e26a92739c168cc4f2a29d9

commit b370649e387d31294e26a92739c168cc4f2a29d9
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Oct 20 14:22:02 2017

Hide 'Password' label for federated credentials on Mac.

Bug:  776652 
Change-Id: Ie45c059be0de803e150d814b6142555883e052b4
Reviewed-on: https://chromium-review.googlesource.com/730724
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510428}
[modify] https://crrev.com/b370649e387d31294e26a92739c168cc4f2a29d9/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

screenshot for Win/Linux/CromeOS

Deleted: no_password_label_linux.png 14.0 KB

	no_password_label_linux.png 14.0 KB View Download

Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5b49cac8ebc27608d632c05462b010faff3493d

commit c5b49cac8ebc27608d632c05462b010faff3493d
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Sat Oct 21 17:00:45 2017

Hide 'Password' label for federated credentials on Mac.

Bug:  776652 
Change-Id: Ie45c059be0de803e150d814b6142555883e052b4
Reviewed-on: https://chromium-review.googlesource.com/730724
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510428}(cherry picked from commit b370649e387d31294e26a92739c168cc4f2a29d9)
Reviewed-on: https://chromium-review.googlesource.com/732463
Cr-Commit-Position: refs/branch-heads/3239@{#136}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/c5b49cac8ebc27608d632c05462b010faff3493d/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9448f2c327e85deb0ec7cfa321952248ba1e0bfb

commit 9448f2c327e85deb0ec7cfa321952248ba1e0bfb
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Sun Oct 22 17:14:26 2017

[Password Manager] Remove "Password" label in a save prompt for federated credentials

TBR=kolos@chromium.org

(cherry picked from commit a97a1a31400d129b46072c2088b6657909bf842b)

Bug:  776652 
Change-Id: Iad3f7745595668279221a27548abe698787bf826
Reviewed-on: https://chromium-review.googlesource.com/729860
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510426}
Reviewed-on: https://chromium-review.googlesource.com/732112
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#139}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/9448f2c327e85deb0ec7cfa321952248ba1e0bfb/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Could some one please help us with a sample test account and website on which we can try this. Also do we need to enable any flag to view this.

This will help the issue to get verified.

Thanks.!

You can visit https://w3c.github.io/webappsec/demos/credential-management/ and sign in via something.

@vasilii: Thanks for the test URL provided.

Rechecked this issue on Windows 10, Mac 10.12.6, Ubuntu 14.04 using chrome version 64.0.3247.0 as per the test link provided in the above comment. "Password" label in a save prompt for federated credentials are not displayed.

Tagging with TE-verified labels.

Rechecked this issue on Windows 10, Mac 10.12.6, Ubuntu 14.04 using chrome version 63.0.3239.16 as per the test link provided in comment#12. "Password" label in a save prompt for federated credentials are not displayed.

Tagging with TE-verified labels for M63