[css-typed-om] CSSKeywordValue.value should never be empty string |
|||||
Issue descriptionCurrently we can set a CSSKeywordValue's value to be "", but "" is not a keyword so this is bad. Spec: https://github.com/w3c/css-houdini-drafts/issues/477 Test failure: FAIL Updating CSSKeywordValue.value with an empty string throws a TypeError assert_throws: function "() => result.value = value" did not throw
,
Oct 31 2017
Adding this to Hotlist-GoodFirstBug. Quite a small change, and the typed cssom code is fairly new & easy to navigate.
,
Oct 31 2017
@nikhil.sahni, would you like to work on this bug?
,
Oct 31 2017
yes I am working on it.
,
Oct 31 2017
Awesome! It doesn't look like you have edit bug access so I can't assign you to the bug. Assigning myself on your behalf. If you are planning to work on more chromium bugs in the future, then let me know and I'll see if I can request edit access for you.
,
Oct 31 2017
Sure Shend !!! I will submit the patch. I have worked on quite a few bugs. https://codereview.chromium.org/search?closed=1&owner=nikhil.sahni&reviewer=&cc=&repo_guid=&base=&project=&private=1&commit=1&created_before=&created_after=&modified_before=&modified_after=&order=&format=html&keys_only=False&with_messages=False&cursor=&limit=30 AND https://chromium-review.googlesource.com/dashboard/nikhil.sahni@samsung.com
,
Oct 31 2017
Submitted patch https://chromium-review.googlesource.com/c/chromium/src/+/745743 for your consideration. Thank You.
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27198849670041c957a26995a60f14bec7f42c5e commit 27198849670041c957a26995a60f14bec7f42c5e Author: nikhil <nikhil.sahni@samsung.com> Date: Tue Oct 31 13:38:46 2017 CSSKeywordValue.value should never be empty string. Currently CSSKeywordValue.value can be set to empty string if empty string is assigned to that,instead it should throw a type error as per below spec. Spec: https://github.com/w3c/css-houdini-drafts/issues/477 BUG: 776647 Change-Id: I4bb635a26e25dcb35d971bb2a7a1b7d3445a6aca Reviewed-on: https://chromium-review.googlesource.com/745743 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#512818} [delete] https://crrev.com/a0fb2177e206fd6698806d5caac39f0beb0af7b7/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssKeywordValue-expected.txt [modify] https://crrev.com/27198849670041c957a26995a60f14bec7f42c5e/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp [modify] https://crrev.com/27198849670041c957a26995a60f14bec7f42c5e/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h [modify] https://crrev.com/27198849670041c957a26995a60f14bec7f42c5e/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.idl
,
Oct 31 2017
Thanks for the help. You also now have edit bug access.
,
Nov 29 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nikhil.s...@samsung.com
, Oct 30 2017