Remove country abbreviation from mobile network operator name when showing default cellular network |
||||
Issue descriptionWhen showing a default cellular network (e,g. when the service isn't available), the UI currently appends a country abbreviation to the mobile network operator name (e.g. "T-Mobile (us)" ). After the service becomes available, the UI just shows the mobile network operator name (e.g. "T-Mobile"). That leads to a confusing transition and a feeling of consistency. It's also unconventional and sometimes misleading (e.g. roaming) to append a country abbreviation to the mobile network operator name. The country abbreviation should simply be removed.
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12514dec6701359771c664a0f86372ae75f5da90 commit 12514dec6701359771c664a0f86372ae75f5da90 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Oct 24 21:42:44 2017 Cellular Networks: Improve Device naming This removes the (country) from Device naming for Cellular devices and also separates the user visible device name from the home provider id. Bug: 776641 Change-Id: I21aaf38dcb8d5bd09282d6363a659b518eb08962 Reviewed-on: https://chromium-review.googlesource.com/731370 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#511270} [modify] https://crrev.com/12514dec6701359771c664a0f86372ae75f5da90/chrome/browser/chromeos/extensions/info_private_api.cc [modify] https://crrev.com/12514dec6701359771c664a0f86372ae75f5da90/chrome/browser/chromeos/status/data_promo_notification.cc [modify] https://crrev.com/12514dec6701359771c664a0f86372ae75f5da90/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js [modify] https://crrev.com/12514dec6701359771c664a0f86372ae75f5da90/chromeos/network/device_state.cc [modify] https://crrev.com/12514dec6701359771c664a0f86372ae75f5da90/chromeos/network/device_state.h [modify] https://crrev.com/12514dec6701359771c664a0f86372ae75f5da90/chromeos/network/network_state_handler.cc [modify] https://crrev.com/12514dec6701359771c664a0f86372ae75f5da90/chromeos/network/shill_property_util.cc [modify] https://crrev.com/12514dec6701359771c664a0f86372ae75f5da90/chromeos/network/shill_property_util.h
,
Oct 24 2017
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09398aae48af00e70b434ad0bea2ca10e5ab7b4f commit 09398aae48af00e70b434ad0bea2ca10e5ab7b4f Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Oct 26 00:18:25 2017 Cellular Networks: Fix Device naming crash This fixes a crash when a Device has no SIM or a locked SIM which can lead to an empty HomeProvider property instead of a dict. Bug: 776641 Change-Id: Ia196eef6dbd5d48385950b6e37c35708215265e2 Reviewed-on: https://chromium-review.googlesource.com/738862 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#511656} [modify] https://crrev.com/09398aae48af00e70b434ad0bea2ca10e5ab7b4f/chromeos/network/device_state.cc
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by benchan@chromium.org
, Oct 20 2017