New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 776627 link

Starred by 1 user
Status: Duplicate
Merged: issue 713376
Owner:
█ wkorman@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Underlined shadowed text renders improperly

Reported by rober...@gmail.com, Oct 20 2017 
UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Example URL:
http://www.j-archive.com/showgame.php?game_id=5438

Steps to reproduce the problem:
1. Go to example URL
2. See category heading ON THE COVER OF ROLLING STONE
3. Compare to how same page renders in Safari, Firefox, Internet Explorer

What is the expected behavior?
Drop shadow should not obscure text underline

What went wrong?
Drop shadow obscures (i.e., sits on a layer "above") the text underline

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 61.0.3163.100  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

HTML code for this particular example is <td class="category_name">ON THE COVER OF <em class="underline">ROLLING STONE</em></td>

In the stylesheet, td.category_name specifies text-shadow: 2px 2px 0px #000000; em.underline specifies   font-style: normal; text-decoration: underline;
chromebug.png
50.6 KB View Download

Comment 1 by krajshree@chromium.org, Oct 23 2017

Components: Blink>Paint
Labels: -Type-Bug -Pri-2 hasbisect-per-revision M-64 Needs-Milestone OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: wkorman@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.6 using chrome reported version #61.0.3163.100 and latest canary #64.0.3247.0.

Bisect Information:
=====================
Good build: 60.0.3075.0	 Revision(465641)
Bad Build : 60.0.3076.0	 Revision(465838)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/c751fcc699b1d5e905870e62f453b326195e55e9..7b4caa4232e5c7246d43fc954264754b6f396bf8

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2820743003

wkorman@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!

Comment 2 by rober...@gmail.com, Oct 23 2017 

According to the cited spec the correct painting order is shadows, underlines, 
overlines, text, emphasis marks, line-through.  Somehow we have text shadows being painted after the underlines of the underlined shadowed text.

Comment 3 by dglazkov@chromium.org, Oct 23 2017

Components: -Blink

Comment 4 by dglazkov@chromium.org, Oct 23 2017

Owner: ----
Status: Untriaged (was: Assigned)

Comment 5 by schenney@chromium.org, Oct 23 2017

Owner: wkorman@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by wkorman@chromium.org, Oct 23 2017

Mergedinto: 713376
Status: Duplicate (was: Assigned)
This is a duplicate of http://crbug.com/713376.

IIRC my change fixed underlines and changed shadow paint behavior, fixing some cases and breaking others. Shadows were already incorrect in some cases before my patch.

The test case in this issue is incorrect on Chrome but renders correctly in FF and Safari. It's a good test case to focus on since the ones I mentioned in the duped issue are more complex. Attached minor reduction.
test.html
218 bytes View Download
►

Sign in to add a comment