Undefined-shift in AllPassFilter |
|||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6193321491038208 Fuzzer: libFuzzer_audio_processing_fuzzer Job Type: libfuzzer_chrome_ubsan Platform Id: linux Crash Type: Undefined-shift Crash Address: Crash State: AllPassFilter SplitFilter WebRtcVad_CalculateFeatures Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=509903:509934 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6193321491038208 Issue filed automatically. See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
,
Oct 24 2017
,
Oct 24 2017
,
Oct 24 2017
It's a pretty clear undefined shift (the value shifted is 16 bit signed sample data). Marking as available for now. It's undefined "in name only".
,
Oct 24 2017
For more information, please see https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md. The link referenced in the description is no longer valid.
,
Oct 25 2017
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/b9f536167c951558cce8ab18a5012e0822d18855 commit b9f536167c951558cce8ab18a5012e0822d18855 Author: Alex Loiko <aleloi@webrtc.org> Date: Wed Oct 25 13:35:36 2017 Removing undefined left shifts in AudioProcessing This CL replaces 5 left shifts where the shifted value may be negative. The shifts are replaced with equivalent multiplications. Bug: chromium:777231 , chromium:776719 , chromium:776624 , chromium:776286 Change-Id: Ifb27d5506eac779e60f238432bdf9e4bc5b2da4c Reviewed-on: https://webrtc-review.googlesource.com/14800 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20430} [modify] https://crrev.com/b9f536167c951558cce8ab18a5012e0822d18855/common_audio/signal_processing/resample_by_2.c [modify] https://crrev.com/b9f536167c951558cce8ab18a5012e0822d18855/common_audio/vad/vad_filterbank.c [modify] https://crrev.com/b9f536167c951558cce8ab18a5012e0822d18855/modules/audio_processing/agc/legacy/digital_agc.c
,
Oct 26 2017
ClusterFuzz has detected this issue as fixed in range 511638:511668. Detailed report: https://clusterfuzz.com/testcase?key=6193321491038208 Fuzzer: libFuzzer_audio_processing_fuzzer Job Type: libfuzzer_chrome_ubsan Platform Id: linux Crash Type: Undefined-shift Crash Address: Crash State: AllPassFilter SplitFilter WebRtcVad_CalculateFeatures Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=509903:509934 Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=511638:511668 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6193321491038208 See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Oct 26 2017
ClusterFuzz testcase 6193321491038208 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pnangunoori@chromium.org
, Oct 23 2017Components: Blink>Media>Audio Blink>WebRTC
Labels: M-64 Test-Predator-Wrong CF-NeedsTriage