Remove CheckPagesExistOffline from OfflinePageModel |
||
Issue descriptionRemove this public API and usage, in both Chromium and Clank repo, since it's no longer used by any external clients. Proposed workflow: 1. [Chromium] Make getAllPages public in OfflinePageBridge.java 2. [Clank] Fix the OfflinePagesHelper.java used by UIAutomatorTests, instead of using CheckPagesExistOffline, use getAllPages. 3. [Chromium] Remove usage in OfflinePageBridgeTest.java and OfflinePageBridge.java, as well as native side.
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/433438603744f944286684e8dd02391fca6411fa commit 433438603744f944286684e8dd02391fca6411fa Author: Yafei Duan <romax@chromium.org> Date: Fri Oct 20 23:17:44 2017 [Offline Pages] Make getAllPages public on Bridge. First step to remove the CheckPagesExistOffline from OfflinePageModel. Making getAllPages is required for later change in Clank repository. Bug: 776616 Change-Id: Ib032b175f6184807a9dc0dbcd4eb30af78f26691 Reviewed-on: https://chromium-review.googlesource.com/731567 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#510601} [modify] https://crrev.com/433438603744f944286684e8dd02391fca6411fa/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java [modify] https://crrev.com/433438603744f944286684e8dd02391fca6411fa/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
,
Oct 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/0a5a5b9c1b47fce188b3421c834bd2faba4b6e8c commit 0a5a5b9c1b47fce188b3421c834bd2faba4b6e8c Author: Yafei Duan <romax@google.com> Date: Wed Oct 25 03:11:00 2017
,
Oct 26 2017
THe last CL is missing the BUG number... Here it is: https://chromium-review.googlesource.com/c/chromium/src/+/716845 |
||
►
Sign in to add a comment |
||
Comment 1 by romax@chromium.org
, Oct 20 2017