New issue
Advanced search Search tips

Issue 776615 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Oct 23
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Mac doesn't pulse tabs affected by tab context menus

Project Member Reported by a...@chromium.org, Oct 20 2017

Issue description

On Views, when a tab context menu would affect tabs, we pulse the affected tabs.

Can we do that on the Mac?
 

Comment 1 by a...@chromium.org, Oct 20 2017

Cc: sdy@chromium.org
I'm playing with this, and attaching the diff.

The problem is that I want to get things to pulse while the menu is open, but the pulsing code is using -[NSObject performSelector:withObject:afterDelay:], which doesn't work during the runloop that runs while the contextual menu is tracking.

Is this worth getting working or should I just rip out the glow code?
pulse.diff
8.3 KB Download

Comment 2 by a...@chromium.org, Oct 20 2017

Cc: tapted@chromium.org

Comment 3 by a...@chromium.org, Oct 20 2017

Cc: a...@chromium.org
Owner: ----
Status: Available (was: Assigned)
So...

Achieving this is pretty simple: https://chromium-review.googlesource.com/c/chromium/src/+/729547

The problem is that all the pulsing is done on a tab-by-tab basis, so while the pulsing starts in sync, it doesn't stay in sync.

For now, I'm ripping out the pulsing code. Perhaps in the future, when it's rewritten in Core Animation, it'll return.
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 22

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Archived (was: Untriaged)
Archiving due to inactivity. If we're still interested in pursuing this, feel free to reopen. Thanks!

Sign in to add a comment