New issue
Advanced search Search tips

Issue 776606 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 734150



Sign in to add a comment

HistoryStateOperationsTest.StateReplacementBackForward fails with WKBasedNavigationManager

Project Member Reported by ajuma@chromium.org, Oct 20 2017

Issue description

This test fails because the text that's supposed to be added to the DOM when the test page (state_operations.html) gets loaded doesn't actually get added after back navigation:

../../ios/web/navigation/history_state_operations_inttest.mm:363: Failure
Value of: IsOnLoadTextVisible()
  Actual: false
Expected: true

The problem seems to be that the window.onload event isn't firing on back navigation. Safari on iOS doesn't fire an onload event in this situation, so we're likely just inheriting this behavior now. Browser behavior in this area is inconsistent. Testing on Mac, Chrome and Safari *do* fire an onload event for back navigation, but Firefox does not.

A good next step for this bug is to figure where/if this behavior is spec'd.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45c981772bda000966bd88f791e693b4c559909c

commit 45c981772bda000966bd88f791e693b4c559909c
Author: Danyao Wang <danyao@chromium.org>
Date: Tue Feb 13 22:49:13 2018

[Nav Experiment] Fix PushAndReplaceStateNavigationTestCase.

WKWebView does not fire a load event for back/forward navigation.
WKBasedNavigationManager inherits this behavior. Updated test
expectation to account for this.

Bug:  776606 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8d81df2eb8b30cf400868c3d384a75d28f731463
Reviewed-on: https://chromium-review.googlesource.com/916840
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536527}
[modify] https://crrev.com/45c981772bda000966bd88f791e693b4c559909c/ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm

Comment 2 by danyao@chromium.org, Mar 14 2018

Status: Fixed (was: Available)

Sign in to add a comment