Issue metadata
Sign in to add a comment
|
NetworkServiceNetworkChangeTest tests started failing in content_unittests on Fuchsia |
||||||||||||||||||||||||
Issue descriptionBoth of these: NetworkServiceNetworkChangeTest.NetworkChangeManagerRequest NetworkServiceTest.NetworkChangeManagerRequest Looking at https://ci.chromium.org/buildbot/chromium.fyi/Fuchsia/?limit=200 Looks like it started at https://ci.chromium.org/buildbot/chromium.fyi/Fuchsia/10349 which makes https://chromium-review.googlesource.com/644352 a suspect.
,
Oct 19 2017
Looks like it's just enumerating platforms and there's no case for Fuchsia.
,
Oct 19 2017
Thanks for looking into it. Feel free to disable the tests in the meanwhile and assign this to me. I will get to it tmr. jam@ has a change in CQ ( https://chromium-review.googlesource.com/729562) which may conflict.
,
Oct 20 2017
We don't have NetworkChangeNotifier on Fuchsia currently, so this is likely the reason these tests fail.
,
Oct 20 2017
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d19d0f0fed7546f9edddd3d338ff9d842d327e03 commit d19d0f0fed7546f9edddd3d338ff9d842d327e03 Author: Helen Li <xunjieli@chromium.org> Date: Mon Oct 23 13:49:57 2017 Skip creating NetworkChangeNotifier if NetworkService is running in process net::NetworkChangeNotifier's constructor checks to see that it is the only instance in the process. If NetworkService is running in process (which happens for some browser tests), an NetworkChangeNotifier would have been created. If so, skip creating a second net::NetworkChangeNotifier in NetworkService. This CL disables the tests for OS_FUCHSIA which doesn't yet have a platform NetworkChangeNotifier implementation. Bug: 776599 , 754709 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia6fa294be7a6d1adb2119aa6d8743fa780216350 Reviewed-on: https://chromium-review.googlesource.com/731244 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#510781} [modify] https://crrev.com/d19d0f0fed7546f9edddd3d338ff9d842d327e03/content/network/network_service_impl.cc [modify] https://crrev.com/d19d0f0fed7546f9edddd3d338ff9d842d327e03/content/network/network_service_unittest.cc [modify] https://crrev.com/d19d0f0fed7546f9edddd3d338ff9d842d327e03/net/base/network_change_notifier.cc [modify] https://crrev.com/d19d0f0fed7546f9edddd3d338ff9d842d327e03/net/base/network_change_notifier.h
,
Oct 23 2017
,
Oct 23 2017
Thanks Helen!
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Sep 11
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by scottmg@chromium.org
, Oct 19 2017