New issue
Advanced search Search tips

Issue 776586 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Chrome crashes after tapping on OK button from promo dialog box

Project Member Reported by mdjones@chromium.org, Oct 19 2017

Issue description

From https://crbug.com/775890:

Chrome crashes after tapping on OK button from promo dialog box

Application Version :Chrome 63.0.3239.10
Android Build Number : 7.1.2/N2G47E
Device: Google Pixel

Precondition:
“Chrome Home Promo”  enabled under chrome:// flags

Steps to reproduce:.
1.Launch chrome
2.Search anything in two tabs> Force stop chrome > Relaunch chrome
3.Put it in multi-window docked to the top of screen > Move one tab to other window > Open new tab in second window >  Tap on the clickable section that trigger promo > Tap on 'OK' from dialog box > Observe


Observed Result:
Chrome Crashes

Expected Result:
Chrome should never crash

 java.lang.AssertionError
 	at org.chromium.chrome.browser.ChromeActivity.markSessionEnd(ChromeActivity.java:2081)
 	at org.chromium.chrome.browser.ChromeActivity.onMultiWindowModeChanged(ChromeActivity.java:1777)
 	at org.chromium.chrome.browser.ChromeTabbedActivity.onMultiWindowModeChanged(ChromeTabbedActivity.java:2218)
 	at android.app.Activity.dispatchMultiWindowModeChanged(Activity.java:6898)
 	at android.app.ActivityThread.handleMultiWindowModeChanged(ActivityThread.java:2964)
 	at android.app.ActivityThread.-wrap14(ActivityThread.java)
 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1711)
 	at android.os.Handler.dispatchMessage(Handler.java:102)
 	at android.os.Looper.loop(Looper.java:154)
 	at android.app.ActivityThread.main(ActivityThread.java:6121)
 	at java.lang.reflect.Method.invoke(Native Method)
 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)

 
I put some logging in the markSessionEnd and markSessionResume methods that control the metrics. I see 3 activities; two for each window, which have *resume and *end called correctly, and a mystery third one that only has *end called when multiwindow changes.
Rather, the activity restarts and one of the two windows must not have native ready yet.
Is #onMultiWindowModeChanged getting called after activity recreation? That seems a bit odd to me.. I didn't think that method was called if the activity started in multi-window mode (only if multi-window changed while the activity was running).
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Removing release block since this is only an assert. We should still figure out why this triggers.

Comment 5 by k...@chromium.org, Oct 24 2017

Labels: Fine-Pri-3.0
Status: WontFix (was: Assigned)
Chrome Home is being turned down so I'm marking this as WontFix.

Sign in to add a comment