[WPT Import] Failure in git_cl.py |
||
Issue descriptionLog: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F3554%2F%2B%2Frecipes%2Fsteps%2FImport_changes_from_WPT_to_Chromium%2F0%2Fstdout Relevant bits: Traceback (most recent call last): File "/mnt/data/b/rr/tmpxIZ6DX/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 25, in <module> main() File "/mnt/data/b/rr/tmpxIZ6DX/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in main host.exit(importer.main()) File "/mnt/data/b/rr/tmpxIZ6DX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 133, in main if not self.update_expectations_for_cl(): File "/mnt/data/b/rr/tmpxIZ6DX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 153, in update_expectations_for_cl self.git_cl.trigger_try_jobs(self.blink_try_bots()) File "/mnt/data/b/rr/tmpxIZ6DX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 58, in trigger_try_jobs builders = builders - {'android_blink_rel'} TypeError: unsupported operand type(s) for -: 'list' and 'set' step returned non-zero exit code: 1 Seems to be from the change in: https://chromium-review.googlesource.com/c/chromium/src/+/726970
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac7032682eef5846db93b890cda53bdb0e5000ba commit ac7032682eef5846db93b890cda53bdb0e5000ba Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Oct 20 00:52:55 2017 Change GitCL.trigger_try_jobs to accept any sequence. GitCL.trigger_try_jobs is called with different types in test_importer.py and rebaseline_cl.py. It's not very complicated to just make it accept any sequence. This CL adds a bug fix and unit test. Bug: 776585 Change-Id: Ie9d57e1d388ef08fb24d78b9a61392a70b76723b Reviewed-on: https://chromium-review.googlesource.com/729541 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#510275} [modify] https://crrev.com/ac7032682eef5846db93b890cda53bdb0e5000ba/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py [modify] https://crrev.com/ac7032682eef5846db93b890cda53bdb0e5000ba/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
,
Oct 20 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by qyears...@chromium.org
, Oct 19 2017