New issue
Advanced search Search tips

Issue 776575 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Enable OCSP tests on Fuchsia

Project Member Reported by sergeyu@chromium.org, Oct 19 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/033501e528806282dc2bebf226cf242a4ad76f39

commit 033501e528806282dc2bebf226cf242a4ad76f39
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Oct 19 22:29:21 2017

Disable OCSP tests on Fuchsia

NOTRY=true

Bug:  776575 
Change-Id: I986136822ee7d835f94af1dffd48399be03ce43a
Reviewed-on: https://chromium-review.googlesource.com/729439
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510242}
[modify] https://crrev.com/033501e528806282dc2bebf226cf242a4ad76f39/net/url_request/url_request_unittest.cc

Comment 2 by eroman@chromium.org, Oct 19 2017

Owner: sergeyu@chromium.org
The issue has to do with how the test server is being run on Fuchsia.

The tests in question which are failing are:

   HTTPSEVCRLSetTest.MissingCRLSetAndGoodOCSP
   HTTPSOCSPTest.Invalid
   HTTPSOCSPTest.Valid
   HTTPSOCSPTest.Revoked

These rely on SpawnedTestServer, which on Fuchsia is implemented by RemoteTestServer (rather than LocalTestServer on other platforms).

Doing a trace of the tests shows that:

The spawner test server is successfully created in the Fuchsia VM, and it invokes "http://192.168.3.2:38420/start".

The test then requests the target HTTPS url "https://127.0.0.1:62095//".

The certificate generated by the test server embeds the following URL for OCSP:

  http://127.0.0.1:35574/ocsp

The tests ultimately fail because the OCSP server running at this port cannot be reached by the code running in VM.

I didn't trace beyond this point to see whether this is caused by the OCSP server not being started, or needing more plumbing to forward it, or not using the right port number.

Sergey, as this is more Fuchsia test setup related can you take a look?
Thanks!
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee7c8db6b554120fb28385f8759695048f1d8612

commit ee7c8db6b554120fb28385f8759695048f1d8612
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Dec 08 00:18:39 2017

Implement OCSP server support in RemoteTestServer.

Previously OCSP was broken with RemoteTestServer because OCSP server
port wasn't proxied.
 1. Updated testserver.py to accept --ocsp-proxy-port-number argument
    which makes it possible to generate correct cerificate for the
    proxied connection.
 2. Updated chrome_test_server_spawner.py to forward oscp server port.
 3. Updated RemtoeTestServer to proxy OCSP connection.
 4. Enabled OCSP tests on Fuchsia where they were previously failing.

Bug:  776575 ,  792300 
Change-Id: Iedb1f5b26fc29ad0c73e78f450cd49335a424c18
Reviewed-on: https://chromium-review.googlesource.com/810096
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522634}
[modify] https://crrev.com/ee7c8db6b554120fb28385f8759695048f1d8612/build/util/lib/common/chrome_test_server_spawner.py
[modify] https://crrev.com/ee7c8db6b554120fb28385f8759695048f1d8612/net/test/spawned_test_server/base_test_server.cc
[modify] https://crrev.com/ee7c8db6b554120fb28385f8759695048f1d8612/net/test/spawned_test_server/base_test_server.h
[modify] https://crrev.com/ee7c8db6b554120fb28385f8759695048f1d8612/net/test/spawned_test_server/remote_test_server.cc
[modify] https://crrev.com/ee7c8db6b554120fb28385f8759695048f1d8612/net/test/spawned_test_server/remote_test_server.h
[modify] https://crrev.com/ee7c8db6b554120fb28385f8759695048f1d8612/net/test/spawned_test_server/remote_test_server_proxy.cc
[modify] https://crrev.com/ee7c8db6b554120fb28385f8759695048f1d8612/net/test/spawned_test_server/remote_test_server_proxy.h
[modify] https://crrev.com/ee7c8db6b554120fb28385f8759695048f1d8612/net/test/spawned_test_server/remote_test_server_proxy_unittests.cc
[modify] https://crrev.com/ee7c8db6b554120fb28385f8759695048f1d8612/net/tools/testserver/testserver.py
[modify] https://crrev.com/ee7c8db6b554120fb28385f8759695048f1d8612/net/url_request/url_request_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment