New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776561 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit 15 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 776961



Sign in to add a comment

iOS history page, text search breaks during pagination

Project Member Reported by s...@chromium.org, Oct 19 2017

Issue description

If you have enough history results from a search to span multiple pages, as you hold touch down to enable scrolling, we'll continuously fetch pages and _REPLACE_ the old contents, until eventually we replace the last page of results with nothing. This essentially breaks scrolling while you have a search query active.

If you don't have enough results to page, then everything works just fine. If you modify history_collection_view_controller.cc's kMaxFetchCount to be lower than 100, something like 10 the issue becomes very apparent.
 

Comment 1 by s...@chromium.org, Oct 19 2017

Labels: -Pri-1 Pri-3
Actually I don't think is a regression. It only seemed to incredibly broken to me because I had set kMaxFetchCount to 10, which means you cannot help but keep paging. With the normal kMaxFetchCount of 100, your results aren't replaced until you scroll to the bottom, which is less awful. Reducing priority.

Comment 2 by s...@chromium.org, Oct 20 2017

Blocking: 776961

Comment 3 by s...@chromium.org, Jan 17 2018

Cc: s...@chromium.org
Owner: ----
Status: Available (was: Assigned)
This really needs to still be fixed. Removing myself as owner due to team transition. The code change this bug requires is awkward right now while the kHistoryBatchUpdatesFilter branch is still in the code. But once that's removed, we really should do this.
Owner: sczs@chromium.org
Status: Assigned (was: Available)
kHistoryBatchUpdatesFilter is now gone, and this is still an issue. Luckily is really hard to repro with kMaxFetchCount=100.

Sign in to add a comment