New issue
Advanced search Search tips

Issue 776557 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Dragging a tab off a ChromeOS-full-screened window leaves user unable to access tabstrip or shelf.

Project Member Reported by w...@chromium.org, Oct 19 2017

Issue description

Chrome Version: 63.0.3239.7
OS: ChromeOS Kevin

What steps will reproduce the problem?
(1) Open a window with multiple tabs.
(2) Press the ChromeOS full-screen button.
(3) Drag one of the tabs to be a separate full-screened window.
(4) Move to the top or bottom of the screen, with the mouse.

What is the expected result?

Expect that the tabstrip or shelf show, at the top & bottom of the screen.

What happens instead?

Neither tabstrip nor shelf show; user must explicitly exit the CrOS full-screen mode.

If you Alt-Tab to the other window, then both shelf and tabstrip will show.

If you then Alt-Tab back to the "broken" window, neither will show.
 

Comment 1 by vadimt@chromium.org, Nov 27 2017

Components: UI>Shell>WindowManager
Labels: Touch-Friendly-Launcher Touch-Friendly-Launcher-Triaged
Labels: -Pri-1 -M-63 Pri-2
Owner: afakhry@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b283b6a011d1e97aefe1d690c9d960c455ddad0

commit 6b283b6a011d1e97aefe1d690c9d960c455ddad0
Author: Ahmed Fakhry <afakhry@google.com>
Date: Fri Dec 01 22:33:41 2017

Fix tab detaching from immersive fullscreen windows

When detaching a tab to a new browser, we used to just fullscreen
the window, which is different from the immersive fullscreen window.
This caused the new window to block showing the shelf as well as
revealing the tab strip.

BUG= 776557 
TEST=interactive_ui_tests --gtest_filter=TabDragging/DetachToBrowserTabDragControllerTest.DetachToOwnWindowWhileInImmersiveFullscreenMode/*

Change-Id: Idd3714fc9ec00e0e771ed93f77b40113c68b0ff9
Reviewed-on: https://chromium-review.googlesource.com/804174
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521094}
[modify] https://crrev.com/6b283b6a011d1e97aefe1d690c9d960c455ddad0/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/6b283b6a011d1e97aefe1d690c9d960c455ddad0/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Status: Fixed (was: Started)
Status: Archived (was: Fixed)

Sign in to add a comment