Issue metadata
Sign in to add a comment
|
Chrome 62 - user-select: none behavior changed and prevents selection in cases it didn't previously |
||||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3202.62 Install https://chrome.google.com/webstore/detail/circ/bebigdkelppomhhjaaianniiifjbgocn?hl=en-US Attempt to select text in the main web view of the CIRC app. OBSERVE: Text selection fails in app on Chrome 62, Chrome 64. Works properly in app on Chrome 61. Perhaps a variant of Issue 761433 ?
,
Oct 19 2017
I don't see "user-select: none" in the source code for the CIRC app, but when I inspect the app in the debugger, that directive is present on the BODY element.
,
Oct 20 2017
Chrome doesn't add user-select:none automatically except for following rule
in UA style sheet:
input[type="button" i], input[type="submit" i], input[type="reset" i] {
-webkit-appearance: push-button;
-webkit-user-select: none;
white-space: pre
}
It seems the framework used in CIRC app does so.
Could you provide minimal reproduce case for this?
,
Oct 20 2017
This has regressed across Mac, Windows, Linux, and Chrome OS. I expect that "user-select: none" is the default for all Chrome App documents. I don't know exactly how that's added, but it doesn't seem to be very relevant. Reduced repro: 1. Extract the ZIP to a local folder (e.g. C:\temp\app) 2. Visit chrome://extensions and tick "Developer mode" 3. Click Load Unpacked Extension 4. Select the folder where the app was unzipped 5. Click Launch 6. Attempt to select the first line of text. Expect: Selectable Actual: Text can only be selected in Chrome 61 and earlier
,
Oct 20 2017
,
Oct 20 2017
You are probably looking for a change made after 489358 (known good), but no later than 489388 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/2c0dbb478638cebb3606d74a69696e63d62529bd..72657e6cdc063501f68c8e95f2cbd9559367ce30 Of these, the suspect remains https://chromium.googlesource.com/chromium/src/+/7a66627f0f0a681fcf3111a9bb0f01a8e0790186
,
Oct 20 2017
A simpler repro is attached; you don't need to use a Chrome App to reproduce this. Chrome Apps simply attach 'user-select: none' to the body automatically, while this repro page adds it explicitly.
,
Oct 20 2017
Confirmed. You are probably looking for a change made after 489362 (known good), but no later than 489363 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/17684e9d8dd252a678cc17989303eaf027cbb61a..7a66627f0f0a681fcf3111a9bb0f01a8e0790186
,
Oct 20 2017
,
Oct 20 2017
,
Oct 20 2017
Not sure this is applicable to Android or not but adding OS=Android as this is blink bug.
,
Oct 20 2017
,
Oct 24 2017
Do we have any progress on the fix here? Since hugoh@ is OOO can someone else look into this issue? elawrence@? Also, does this really affected Android?
,
Oct 24 2017
The POC in #8 doesn't seem to impact Android at all. In terms of fixing, maybe ask the reviewers of the regressing CL for suggestions?
,
Oct 24 2017
FWIW, I think the new Chrome 62+ behavior matches the CSS4 draft specification: https://drafts.csswg.org/css-ui-4/#content-selection auto The computed value of auto is determined as follows: ... if the computed value of user-select on the parent of this element is none, the computed value is none Because the CIRC app is using -webkit-user-select: initial instead of -webkit-user-select: text, and initial==auto, this ends up meaning 'none'. Firefox 56 matches the new Chrome behavior (if the vendor prefixed version -webkit-user-select is specified on the text) Safari 11.0 allows the selection if ANY -webkit-user-select value is specified on the text, including auto or initial.
,
Oct 24 2017
elawrence@ regarding #16, if Chrome62 is following the specifications, does that mean this needs a change on the CIRC app side? Can we remove RB-Stable from this bug, since this may not necessarily be a Chrome bug.
,
Oct 24 2017
I don't think the currently-known impact warrants a Release-Block-Stable tag, but it seems probable that other scenarios are impacted and they simply haven't yet reached our notice. For instance, the regressing CL also caused Issue 761433 , and over the course of the next few weeks after I reported that issue, other impacted sites and scenarios trickled in. I submitted a pull request for the CIRC app a few days ago: https://github.com/flackr/circ/pull/424 but I haven't yet received a response. It's possible that the project was abandoned by the maintainer.
,
Oct 24 2017
Removing RB-Stable per comment #18
,
Oct 26 2017
It turns out that the developer of CIRC works on Chrome and accepted my PR. So that app is no longer impacted. Leaving this bug alive only so hugoh@ can confirm that we want to keep the behavioral change despite potential compat impact.
,
Oct 30 2017
Yes, we want to keep current behavior because it aligns us with the CSS spec.
,
Nov 3 2017
The NextAction date has arrived: 2017-11-03 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by elawrence@chromium.org
, Oct 19 2017