In the chrome side there are a number of unittests that exercise mus specific functionality and need to be run on the main waterfall.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/348ecf7e5218bb0b3276ad7cdfe79610f987f37e commit 348ecf7e5218bb0b3276ad7cdfe79610f987f37e Author: Scott Violet <sky@chromium.org> Date: Tue Nov 28 18:28:19 2017 ui-service: updates AuraTest* to more correctly do the right thing Prior to this patch AuraTestHelper configured TestScreen in such a way that it would create a WindowTreeHost to represent a screen. The WindowTreeHost was created was not a WindowTreeHostMus, rather a WindowTreeHostPlatform. This doesn't make sense for mus. As part of this I'm also moving how ash configures Env to AuraTestBase. This way other code using AuraTestBase can work better with mus. Lastly I needed to make sure sure AuraTestHelper resets some state that was persisting between runs. This is necessitated by Env being created at the TestSuite level, not per test. BUG= 776514 TEST=covered by tests Change-Id: Icb1b5342f962f44c03185a3e40097491532c4efe Reviewed-on: https://chromium-review.googlesource.com/791821 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#519758} [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ash/test/ash_test_suite.cc [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/components/exo/BUILD.gn [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/components/exo/wayland/BUILD.gn [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/BUILD.gn [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/DEPS [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/aura_mus_test_base.cc [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/aura_mus_test_base.h [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/aura_test_base.cc [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/aura_test_base.h [add] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/aura_test_context_factory.cc [add] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/aura_test_context_factory.h [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/aura_test_helper.cc [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/aura_test_helper.h [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/mus/window_tree_client_private.cc [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/aura/test/test_screen.cc [modify] https://crrev.com/348ecf7e5218bb0b3276ad7cdfe79610f987f37e/ui/views/mus/views_mus_test_suite.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f417bb7fd82e2a5e46f528c63894297f08f8771 commit 8f417bb7fd82e2a5e46f528c63894297f08f8771 Author: Scott Violet <sky@chromium.org> Date: Tue Nov 28 23:06:53 2017 aura: adds AuraTestSuiteSetup to configure Env and mus The current pattern for test suites that *may* use aura has the test suite create aura::Env. In order to enable mus more broadly we need to make it so that the test suite configures Env appropriate for mus. This patch adds AuraTestSuiteSetup that is meant to setup the necessary state at the test suite level for tests that may use aura. It looks at the command line and potentially enables mus as appropriate. In order to setup env for mus WindowTreeClient needs to be configured, which required moving around some stubs. I had to update AuraTestHelper for mus being configured at the global level. This is mildly complicated by the fact that AuraTestHelper wants to create its own WindowTreeClient in this case. BUG= 776514 TEST=covered by tests Change-Id: Ie433e4f6afe58b2aa15bdfb08fe462c6c1a30fad Reviewed-on: https://chromium-review.googlesource.com/792455 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#519884} [add] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ash/mus/window_manager_unittest.cc [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ash/test/ash_test_helper.cc [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ash/test/ash_test_helper.h [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ash/window_manager_unittest.cc [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/content/public/test/unittest_test_suite.cc [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/content/public/test/unittest_test_suite.h [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/services/ui/ws/window_manager_client_unittest.cc [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/BUILD.gn [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/env.h [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/DEPS [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/aura_test_helper.cc [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/aura_test_helper.h [add] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/aura_test_suite_setup.cc [add] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/aura_test_suite_setup.h [add] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/env_test_helper.cc [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/env_test_helper.h [add] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/mus/test_window_manager_delegate.cc [add] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/mus/test_window_manager_delegate.h [add] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/mus/test_window_tree_client_delegate.cc [add] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/mus/test_window_tree_client_delegate.h [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/mus/test_window_tree_client_setup.cc [modify] https://crrev.com/8f417bb7fd82e2a5e46f528c63894297f08f8771/ui/aura/test/mus/test_window_tree_client_setup.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85b4b6c7fccf0efaab1e1a906af129ea2d3cd732 commit 85b4b6c7fccf0efaab1e1a906af129ea2d3cd732 Author: Scott Violet <sky@chromium.org> Date: Wed Dec 13 05:27:16 2017 chromeos: get EasyUnlockPrivateApiTests working with mus Creating BluezDBusManager is unnecessary for --mus, as WindowManagerService (in ash) takes care of it. BUG= 776514 TEST=test only change Change-Id: Ie3b7e39a507a9263779ce8f1045141e51d81192f Reviewed-on: https://chromium-review.googlesource.com/823526 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523697} [modify] https://crrev.com/85b4b6c7fccf0efaab1e1a906af129ea2d3cd732/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8f5ecbe1f808d4cf46cb4de709e6cfd2de23b20 commit b8f5ecbe1f808d4cf46cb4de709e6cfd2de23b20 Author: Scott Violet <sky@chromium.org> Date: Wed Dec 13 18:22:18 2017 chromeos: makes it possible for unittests to honor --mus This makes it so aura::Env is configured for mus if --mus is specified on the command line. BUG= 776514 TEST=test only change Change-Id: Iaeb80b571e274f5bae9af7688d6b55b79e43b3d2 Reviewed-on: https://chromium-review.googlesource.com/823568 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523824} [modify] https://crrev.com/b8f5ecbe1f808d4cf46cb4de709e6cfd2de23b20/ash/test/ash_test_helper.h [modify] https://crrev.com/b8f5ecbe1f808d4cf46cb4de709e6cfd2de23b20/chrome/test/BUILD.gn [modify] https://crrev.com/b8f5ecbe1f808d4cf46cb4de709e6cfd2de23b20/chrome/test/base/chrome_unit_test_suite.cc [modify] https://crrev.com/b8f5ecbe1f808d4cf46cb4de709e6cfd2de23b20/chrome/test/base/chrome_unit_test_suite.h
It looks like the last blocker is around 20 tests making use of DeviceDataManagerTestAPI, which won't work with DeviceDataManager running in mus.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/529188b81822a8a245ec51c40782f93875426d3d commit 529188b81822a8a245ec51c40782f93875426d3d Author: Scott Violet <sky@chromium.org> Date: Fri Dec 15 20:07:24 2017 chromeos: adds InputDeviceClientTestApi It's used for poking at InputDeviceClient. As Chrome/Ash use DeviceDataManager in classic mode InputDeviceClientTestApi handles both. That is, if DeviceDataManager exists it pokes at it, otherwise InputDeviceClient. BUG= 776514 TEST=test only changes Change-Id: I4e46dbe74dbce4a37d2b4e054b8fec88d4b5a048 Reviewed-on: https://chromium-review.googlesource.com/829713 Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524447} [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/ash/BUILD.gn [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/ash/system/power/peripheral_battery_notifier_unittest.cc [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler_unittest.cc [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/chrome/test/BUILD.gn [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/services/ui/public/cpp/input_devices/BUILD.gn [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/services/ui/public/cpp/input_devices/input_device_client.cc [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/services/ui/public/cpp/input_devices/input_device_client.h [add] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/services/ui/public/cpp/input_devices/input_device_client_test_api.cc [add] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/services/ui/public/cpp/input_devices/input_device_client_test_api.h [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/ui/display/manager/chromeos/DEPS [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/ui/events/BUILD.gn [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/ui/events/devices/device_data_manager.h [modify] https://crrev.com/529188b81822a8a245ec51c40782f93875426d3d/ui/events/devices/device_data_manager_unittest.cc [delete] https://crrev.com/b01b47e4f6705f0a98c28efa860c5374d2da9412/ui/events/test/device_data_manager_test_api.h [delete] https://crrev.com/b01b47e4f6705f0a98c28efa860c5374d2da9412/ui/events/test/device_data_manager_test_api_impl.cc [delete] https://crrev.com/b01b47e4f6705f0a98c28efa860c5374d2da9412/ui/events/test/device_data_manager_test_api_stub.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0722ecfa184396ba42c69c1d383435aeb3a0b2d commit b0722ecfa184396ba42c69c1d383435aeb3a0b2d Author: Scott Violet <sky@chromium.org> Date: Fri Dec 15 22:34:55 2017 chromeos: removes ForTesting functions in factor of TestApi The TestApi class now handles all this, so no reason for the public virtual ForTesting functions. BUG= 776514 TEST=test only changes Change-Id: I1e8165fe1747a7b1b0c1ccfc4f2d0f036eb5d3b5 Reviewed-on: https://chromium-review.googlesource.com/830685 Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524494} [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/ash/display/touch_calibrator_controller_unittest.cc [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/ash/system/ime/tray_ime_chromeos_unittest.cc [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler_unittest.cc [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/services/ui/public/cpp/input_devices/input_device_client.cc [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/services/ui/public/cpp/input_devices/input_device_client.h [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/services/ui/public/cpp/input_devices/input_device_client_test_api.cc [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/ui/events/devices/device_data_manager.cc [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/ui/events/devices/device_data_manager.h [modify] https://crrev.com/b0722ecfa184396ba42c69c1d383435aeb3a0b2d/ui/events/devices/input_device_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d3206cee73a9a526f8b4a0dd4436bbc9a7e3ae0 commit 0d3206cee73a9a526f8b4a0dd4436bbc9a7e3ae0 Author: Scott Violet <sky@chromium.org> Date: Wed Jan 03 00:56:26 2018 chromeos: get OobeDisplayChooserTest tests working for mus These tests used DeviceDataManager directly, which doesn't work for mus. The fix is to use InputDeviceClientTestApi. PreferTouchAsPrimary required an additional call because unit tests don't really bring up mus. BUG= 776514 TEST=test only changes Change-Id: Ica853e72d97bada225004bda7d30b507cef4cab0 Reviewed-on: https://chromium-review.googlesource.com/847688 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#526556} [modify] https://crrev.com/0d3206cee73a9a526f8b4a0dd4436bbc9a7e3ae0/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser_unittest.cc [modify] https://crrev.com/0d3206cee73a9a526f8b4a0dd4436bbc9a7e3ae0/services/ui/public/cpp/input_devices/input_device_client_test_api.cc [modify] https://crrev.com/0d3206cee73a9a526f8b4a0dd4436bbc9a7e3ae0/services/ui/public/cpp/input_devices/input_device_client_test_api.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70667be89f372e09a984d99377468a20b8d55c6e commit 70667be89f372e09a984d99377468a20b8d55c6e Author: Scott Violet <sky@chromium.org> Date: Wed Jan 03 20:22:54 2018 chromeos: add unit_tests --mus to mojo FYI waterfall Also renames mojo_chromiumos_gtests to mojo_chromiumos_fyi_gtests to make it clear this only applies to the FYI waterfall. BUG= 776514 TEST=test only changes Change-Id: I5ae831753a81e1f8eac54c01272c7cdd16017bab Reviewed-on: https://chromium-review.googlesource.com/848272 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526786} [modify] https://crrev.com/70667be89f372e09a984d99377468a20b8d55c6e/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/70667be89f372e09a984d99377468a20b8d55c6e/testing/buildbot/test_suites.pyl [modify] https://crrev.com/70667be89f372e09a984d99377468a20b8d55c6e/testing/buildbot/waterfalls.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a687ee24d5aadf39cdee3842b023ba9aa64ff72f commit a687ee24d5aadf39cdee3842b023ba9aa64ff72f Author: Scott Violet <sky@chromium.org> Date: Fri Jan 05 19:46:10 2018 chromeos: adds content_unittest and unit_tests --mus to main waterfall As well as removing the filter file for 'content_browser_tests --mus'. All of these have been running on the mojo fyi bot without failure. BUG= 785536 , 776514 TEST=test only changes Change-Id: I387398f87b5726c736634588477d85ab737e1c42 Reviewed-on: https://chromium-review.googlesource.com/850721 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#527349} [modify] https://crrev.com/a687ee24d5aadf39cdee3842b023ba9aa64ff72f/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/a687ee24d5aadf39cdee3842b023ba9aa64ff72f/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/a687ee24d5aadf39cdee3842b023ba9aa64ff72f/testing/buildbot/chromium.memory.json [modify] https://crrev.com/a687ee24d5aadf39cdee3842b023ba9aa64ff72f/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/15d7d35c2470c8e276046790fc41d8969419f11e/testing/buildbot/filters/mus.content_browsertests.filter [modify] https://crrev.com/a687ee24d5aadf39cdee3842b023ba9aa64ff72f/testing/buildbot/test_suites.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24c4b23994a4d653353dad5818dd626908140e8f commit 24c4b23994a4d653353dad5818dd626908140e8f Author: Alice Boxhall <aboxhall@chromium.org> Date: Mon Jan 08 04:39:43 2018 Revert "chromeos: adds content_unittest and unit_tests --mus to main waterfall" This reverts commit a687ee24d5aadf39cdee3842b023ba9aa64ff72f. Reason for revert: This caused test shards to start timing out: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25560 Original change's description: > chromeos: adds content_unittest and unit_tests --mus to main waterfall > > As well as removing the filter file for 'content_browser_tests > --mus'. All of these have been running on the mojo fyi bot without > failure. > > BUG= 785536 , 776514 > TEST=test only changes > > Change-Id: I387398f87b5726c736634588477d85ab737e1c42 > Reviewed-on: https://chromium-review.googlesource.com/850721 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#527349} TBR=sky@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 785536 , 776514 Change-Id: I4bc5da6ebcf1dee8bbc98c2a028e06e50e303c53 Reviewed-on: https://chromium-review.googlesource.com/852601 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#527568} [modify] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/chromium.memory.json [modify] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/filters/BUILD.gn [add] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/filters/mus.content_browsertests.filter [modify] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/test_suites.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d268d267d4cde92013a5189033ec61ff47d2625 commit 8d268d267d4cde92013a5189033ec61ff47d2625 Author: Scott Violet <sky@chromium.org> Date: Tue Jan 09 16:16:39 2018 reland: chromeos: adds content_unittest and unit_tests --mus to main waterfall As well as removing the filter file for 'content_browser_tests --mus'. All of these have been running on the mojo fyi bot without failure. BUG= 785536 , 776514 TEST=test only changes Change-Id: I10a7f7e6d257ec2fbb42793e4b607248ec91ae68 Reviewed-on: https://chromium-review.googlesource.com/854724 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#528012} [modify] https://crrev.com/8d268d267d4cde92013a5189033ec61ff47d2625/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/8d268d267d4cde92013a5189033ec61ff47d2625/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/8d268d267d4cde92013a5189033ec61ff47d2625/testing/buildbot/chromium.memory.json [modify] https://crrev.com/8d268d267d4cde92013a5189033ec61ff47d2625/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/fd8e1c8da7222a1ac2391d2e7504bca3e3df0453/testing/buildbot/filters/mus.content_browsertests.filter [modify] https://crrev.com/8d268d267d4cde92013a5189033ec61ff47d2625/testing/buildbot/test_suites.pyl
Comment 1 by sky@chromium.org
, Oct 19 2017