There are a number of mus specific code paths in content that need to tested.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb8b1e36c1e76fd251672e8b3bfda887917fc06f commit fb8b1e36c1e76fd251672e8b3bfda887917fc06f Author: Scott Violet <sky@chromium.org> Date: Fri Nov 03 17:29:59 2017 Makes WMTestHelper work with mus WMTestHelper is used by content_shell and content_browsertests. This patch makes it work with mus. Specifically it connects to mus in such a way that a single WindowTreeHostMus is created. This is needed to get content_browsertests working with --mus (and later --mash). BUG= 776513 TEST=none Change-Id: I1ad9daf1bac8e2726069fd2d55d7ab10dd68641f Reviewed-on: https://chromium-review.googlesource.com/752578 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#513820} [modify] https://crrev.com/fb8b1e36c1e76fd251672e8b3bfda887917fc06f/content/shell/browser/shell_views.cc [modify] https://crrev.com/fb8b1e36c1e76fd251672e8b3bfda887917fc06f/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/fb8b1e36c1e76fd251672e8b3bfda887917fc06f/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/fb8b1e36c1e76fd251672e8b3bfda887917fc06f/ui/views_content_client/views_content_client_main_parts_chromeos.cc [modify] https://crrev.com/fb8b1e36c1e76fd251672e8b3bfda887917fc06f/ui/wm/BUILD.gn [modify] https://crrev.com/fb8b1e36c1e76fd251672e8b3bfda887917fc06f/ui/wm/test/DEPS [modify] https://crrev.com/fb8b1e36c1e76fd251672e8b3bfda887917fc06f/ui/wm/test/wm_test_helper.cc [modify] https://crrev.com/fb8b1e36c1e76fd251672e8b3bfda887917fc06f/ui/wm/test/wm_test_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2eb9229a05200e1d95732c6da350fc9d447d4451 commit 2eb9229a05200e1d95732c6da350fc9d447d4451 Author: Scott Violet <sky@chromium.org> Date: Mon Nov 06 22:53:10 2017 chromeos: move starting UI service for --mus to content Content effectively depends upon the UI service (aka mus) because content uses aura, and aura is on top of mus. This moves launching of the UI service to content (just for the in process case, the --mash case will be done later). This is a necessary step to have content_browsertests use the UI service. BUG= 776513 TEST=none Change-Id: If7ed7b00c12b9fb521fd53c64aa24b398c0f6155 Reviewed-on: https://chromium-review.googlesource.com/754087 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#514271} [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/BUILD.gn [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/app/BUILD.gn [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/app/chrome_main.cc [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/browser/BUILD.gn [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/browser/browser_process_platform_part_chromeos.cc [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/browser/browser_process_platform_part_chromeos.h [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/browser/chrome_content_browser_client.cc [delete] https://crrev.com/a5ea255f5a86b495ed3caa6aa9590d0d03868d5b/chrome/browser/embedded_ui_service_info_factory.cc [delete] https://crrev.com/a5ea255f5a86b495ed3caa6aa9590d0d03868d5b/chrome/browser/embedded_ui_service_info_factory.h [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/browser/ui/ash/ash_init.cc [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/common/BUILD.gn [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/common/chrome_switches.cc [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/common/chrome_switches.h [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/common/features.gni [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/test/BUILD.gn [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/test/base/mash_browser_tests_main.cc [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/utility/BUILD.gn [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/content/browser/BUILD.gn [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/content/browser/browser_main_loop.cc [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/content/browser/browser_main_loop.h [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/content/public/app/BUILD.gn [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/content/public/test/test_launcher.cc [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/content/shell/browser/content_shell_browser_manifest_overlay.json [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/docs/ozone_overview.md [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/tools/mb/mb_config.pyl [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/ui/base/BUILD.gn [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/ui/base/ui_base_switches.cc [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/ui/base/ui_base_switches.h [modify] https://crrev.com/2eb9229a05200e1d95732c6da350fc9d447d4451/ui/base/ui_features.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/537b23e5b96218f3bc3a1fa79feede03b73e4696 commit 537b23e5b96218f3bc3a1fa79feede03b73e4696 Author: Scott Violet <sky@chromium.org> Date: Wed Nov 08 00:53:11 2017 chromeos: adds ui::test to list of required interfaces for content_browsertests Some tests need this. BUG= 776513 TEST=none Change-Id: Iecd8875bf5caa845b6a45c8057c5fe6356e14d2b Reviewed-on: https://chromium-review.googlesource.com/757560 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#514683} [modify] https://crrev.com/537b23e5b96218f3bc3a1fa79feede03b73e4696/content/shell/browser/content_shell_browser_manifest_overlay.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adf969a7cb9ee663fe7083f0f94faa05d81d2e0d commit adf969a7cb9ee663fe7083f0f94faa05d81d2e0d Author: Scott Violet <sky@chromium.org> Date: Wed Nov 08 17:34:15 2017 chromeos: adds content_browsertests --mus to FYI bot I'm still going through the filter file, but would like to run this on the bots for a while to see how it fares. BUG= 776513 TEST=none Change-Id: I194a35aa647f241c6e500070828442768c7c3aa0 Reviewed-on: https://chromium-review.googlesource.com/758699 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#514871} [modify] https://crrev.com/adf969a7cb9ee663fe7083f0f94faa05d81d2e0d/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/adf969a7cb9ee663fe7083f0f94faa05d81d2e0d/testing/buildbot/filters/BUILD.gn [add] https://crrev.com/adf969a7cb9ee663fe7083f0f94faa05d81d2e0d/testing/buildbot/filters/mojo.fyi.mus.content_browsertests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27b0640ff14c37ed9eefdb60fddd3118747e90c2 commit 27b0640ff14c37ed9eefdb60fddd3118747e90c2 Author: Scott Violet <sky@chromium.org> Date: Wed Nov 08 19:48:57 2017 chromeos: exclude two tests that are failing on the bog Will figure out why they are failing separately. BUG= 776513 TEST=none TBR=msw@chromium.org Change-Id: Iea12b7d23f1edb2731c7a178ae1b958a2016ebc0 Reviewed-on: https://chromium-review.googlesource.com/758498 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#514913} [modify] https://crrev.com/27b0640ff14c37ed9eefdb60fddd3118747e90c2/testing/buildbot/filters/mojo.fyi.mus.content_browsertests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42723eb1f34ba953f4a8bbc9cc3532efb60c32f7 commit 42723eb1f34ba953f4a8bbc9cc3532efb60c32f7 Author: Scott Violet <sky@chromium.org> Date: Fri Nov 10 00:11:42 2017 chromeos: adds more comments to mojo.fyi.mus.content_browsertests.filter I'm a bit hand wavy here as my hope is all this goes away once --mus no longer includes Viz. Will need to reevaluate then. BUG= 776513 TEST=test only changes Change-Id: Ib680763d2ad09d6389400e788b9bd434910144f6 Reviewed-on: https://chromium-review.googlesource.com/761709 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515357} [modify] https://crrev.com/42723eb1f34ba953f4a8bbc9cc3532efb60c32f7/testing/buildbot/filters/mojo.fyi.mus.content_browsertests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5ea2e50033749a359a4aca2112034545d3a8ba2 commit e5ea2e50033749a359a4aca2112034545d3a8ba2 Author: Scott Violet <sky@chromium.org> Date: Fri Nov 10 18:36:15 2017 Changes ScreenOrientationBrowserTest to not send resize for all frames This causes problems for mus, because the sizes sent by this function are *not* the right size for the child. Additionally updates ResizeParams::new_size to match the actual size. Without this a DCHECK is hit because the size is set to 0,0, so that when RenderWidget goes to send the new size to the browser a DCHECK is hit (we assume size is never empty). BUG= 776513 TEST=test only changes No-Equivalent-Builders: true Change-Id: I8626bee82a1235fbf77ea47f9365cf1b515d05f9 Reviewed-on: https://chromium-review.googlesource.com/761557 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515609} [modify] https://crrev.com/e5ea2e50033749a359a4aca2112034545d3a8ba2/content/browser/screen_orientation/screen_orientation_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/900e31c21691c8e0ef69d374a5625d8dcf9a9a10 commit 900e31c21691c8e0ef69d374a5625d8dcf9a9a10 Author: Scott Violet <sky@chromium.org> Date: Tue Nov 14 02:45:30 2017 chromeos: adds content_browsertests --mus to main waterfall The FYI bot hasn't failed all weekend. BUG= 776513 TEST=test only changes Change-Id: I354a6cfa5667af6eb5cd12651efe92df3151893a Reviewed-on: https://chromium-review.googlesource.com/767187 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#516155} [modify] https://crrev.com/900e31c21691c8e0ef69d374a5625d8dcf9a9a10/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/900e31c21691c8e0ef69d374a5625d8dcf9a9a10/testing/buildbot/filters/BUILD.gn [add] https://crrev.com/900e31c21691c8e0ef69d374a5625d8dcf9a9a10/testing/buildbot/filters/mus.content_browsertests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc4503a1cdfea2feb0051a0b5b50359ed2b0eb0b commit dc4503a1cdfea2feb0051a0b5b50359ed2b0eb0b Author: Scott Violet <sky@chromium.org> Date: Thu Nov 16 16:35:16 2017 chromeos: adds content_browsertests --mus to main waterfall (again) Apparently the main waterfall now runs linux-chromeos-rel, so add content_browsertests --mus to it. BUG= 776513 TEST=test only changes Change-Id: I342b2a9ff107c870c15b9b8ffebd413ccc9d38f1 Reviewed-on: https://chromium-review.googlesource.com/773286 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#517105} [modify] https://crrev.com/dc4503a1cdfea2feb0051a0b5b50359ed2b0eb0b/testing/buildbot/chromium.chromiumos.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb61139b51af6cb30a94c6f5d36b6727909da944 commit eb61139b51af6cb30a94c6f5d36b6727909da944 Author: Jonathan <jonross@chromium.org> Date: Fri Nov 24 15:33:14 2017 Disable Failng WebRTC tests on FYI Both WebRtcCaptureFromElementBrowserTest.CaptureFromOpaqueCanvas2DHandlesContextLoss WebRtcCaptureFromElementBrowserTest.CaptureFromCanvas2DHandlesContextLoss are failing on mus_content_browsertests as the tab capture feature does not work in the mus config yet. Disabling them on the FYI bot TBR=kylechar@chromium.org TEST=WebRtc`CaptureFromElementBrowserTest.CaptureFromOpaqueCanvas2DHandlesContextLoss, WebRtcCaptureFromElementBrowserTest.CaptureFromCanvas2DHandlesContextLoss Bug: 776513 Change-Id: Ia71b2a3f3bf09652a7e15daa5727e5173a555e43 Reviewed-on: https://chromium-review.googlesource.com/789230 Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#519119} [modify] https://crrev.com/eb61139b51af6cb30a94c6f5d36b6727909da944/testing/buildbot/filters/mojo.fyi.mus.content_browsertests.filter
Comment 1 by sky@chromium.org
, Nov 2 2017Status: Started (was: Available)