[MD Extensions] opening/closing in-page options dialog should not reload the whole page. |
||
Issue descriptionrepro step: 1) unpack src/chrome/test/data/extensions/options_page_in_view 2) go to its detail-view and click on "options" 3) close the options dialog 4) repeat. Notice the page fades in/out as you open/close the dialog, which shouldn't happen
,
Nov 30 2017
The original CL that introduced animateCurrentView() is at https://chromium-review.googlesource.com/c/chromium/src/+/619587, and it seems to validate my theory.
,
Nov 30 2017
Posting before after screencasts. CL candidate is at https://chromium-review.googlesource.com/c/chromium/src/+/802141.
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05f8ea6608884a96bc9be421ef8c5f23afee51a1 commit 05f8ea6608884a96bc9be421ef8c5f23afee51a1 Author: dpapad <dpapad@chromium.org> Date: Thu Nov 30 23:48:57 2017 MD Extensions: Remove unnecessary fade-in/out when options dialog opens/closes. The extra animation was introduced at crrev.com/c/619587, where at the time the code was simulating a transition between the apps and extensions pages (which were implemented as as a single page). This animation is no longer necessary and in fact causes the problem when opening the in-page options dialog. Bug: 776507 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifd94b447b17673c04dfe227d1bd3d70bc87e3870 Reviewed-on: https://chromium-review.googlesource.com/802141 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#520753} [modify] https://crrev.com/05f8ea6608884a96bc9be421ef8c5f23afee51a1/chrome/browser/resources/md_extensions/manager.js [modify] https://crrev.com/05f8ea6608884a96bc9be421ef8c5f23afee51a1/chrome/browser/resources/md_extensions/view_manager.js
,
Dec 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by dpa...@chromium.org
, Nov 30 2017Status: Started (was: Available)